refactor: Rename for better clarity

Infomaniak · Nov 22, 2024 · a7184a0 · a7184a0
1 parent 71252af
commit a7184a0
Show file tree

Hide file tree

Showing 10 changed files with 23 additions and 23 deletions.
diff --git a/app/src/main/java/com/infomaniak/mail/data/api/ApiRepository.kt b/app/src/main/java/com/infomaniak/mail/data/api/ApiRepository.kt
@@ -435,7 +435,7 @@ object ApiRepository : ApiRepositoryCore() {
         return callApi(url = ApiRoutes.shareLink(mailboxUuid, folderId, mailId), method = POST)
     }
 
-    fun getDownloadedAttachment(mailboxUuid: String, folderId: String, shortUid: Int): Response {
+    fun getDownloadedMessage(mailboxUuid: String, folderId: String, shortUid: Int): Response {
         val request = Request.Builder().url(ApiRoutes.downloadMessage(mailboxUuid, folderId, shortUid))
             .headers(HttpUtils.getHeaders(null))
             .get()

diff --git a/app/src/main/java/com/infomaniak/mail/ui/MainViewModel.kt b/app/src/main/java/com/infomaniak/mail/ui/MainViewModel.kt
@@ -923,7 +923,7 @@ class MainViewModel @Inject constructor(
         val message = messageController.getMessage(messageUid) ?: return@launch
         val mailbox = currentMailbox.value ?: return@launch
 
-        val response = ApiRepository.getDownloadedAttachment(mailbox.uuid, message.folderId, message.shortUid)
+        val response = ApiRepository.getDownloadedMessage(mailbox.uuid, message.folderId, message.shortUid)
 
         if (!response.isSuccessful || response.body == null) {
             reportDisplayProblemTrigger.postValue(Unit)

diff --git a/app/src/main/java/com/infomaniak/mail/ui/main/folder/TwoPaneFragment.kt b/app/src/main/java/com/infomaniak/mail/ui/main/folder/TwoPaneFragment.kt
@@ -41,7 +41,7 @@ import com.infomaniak.mail.ui.MainActivity
 import com.infomaniak.mail.ui.MainViewModel
 import com.infomaniak.mail.ui.main.search.SearchFragment
 import com.infomaniak.mail.ui.main.thread.ThreadFragment
-import com.infomaniak.mail.ui.main.thread.actions.DownloadThreadsProgressDialog.Companion.DOWNLOAD_THREADS_RESULT
+import com.infomaniak.mail.ui.main.thread.actions.DownloadMessagesProgressDialog
 import com.infomaniak.mail.utils.extensions.*
 import javax.inject.Inject
 
@@ -121,7 +121,7 @@ abstract class TwoPaneFragment : Fragment() {
 
     private fun observeThreadNavigation() = with(twoPaneViewModel) {
         getBackNavigationResult(AttachmentExtensions.DOWNLOAD_ATTACHMENT_RESULT, ::startActivity)
-        getBackNavigationResult(DOWNLOAD_THREADS_RESULT, ::startActivity)
+        getBackNavigationResult(DownloadMessagesProgressDialog.DOWNLOAD_MESSAGES_RESULT, ::startActivity)
 
         newMessageArgs.observe(viewLifecycleOwner) {
             safeNavigateToNewMessageActivity(args = it.toBundle())

diff --git a/.../actions/DownloadThreadsProgressDialog.kt → ...actions/DownloadMessagesProgressDialog.kt b/.../actions/DownloadThreadsProgressDialog.kt → ...actions/DownloadMessagesProgressDialog.kt
@@ -33,9 +33,9 @@ import com.infomaniak.mail.utils.KDriveUtils.canSaveOnKDrive
 import dagger.hilt.android.AndroidEntryPoint
 
 @AndroidEntryPoint
-class DownloadThreadsProgressDialog : DownloadProgressDialog() {
-    private val downloadThreadsViewModel: DownloadThreadsViewModel by viewModels()
-    private val navigationArgs: DownloadThreadsProgressDialogArgs by navArgs()
+class DownloadMessagesProgressDialog : DownloadProgressDialog() {
+    private val downloadThreadsViewModel: DownloadMessagesViewModel by viewModels()
+    private val navigationArgs: DownloadMessagesProgressDialogArgs by navArgs()
     override val dialogTitle: String? by lazy { getDialogTitleFromArgs() }
     override val dialogIconDrawableRes: Int? by lazy { null }
 
@@ -45,7 +45,7 @@ class DownloadThreadsProgressDialog : DownloadProgressDialog() {
                 popBackStackWithError()
             } else {
                 ArrayList(threadUris).openKDriveOrPlayStore(requireContext())?.let { openKDriveIntent ->
-                    setBackNavigationResult(DOWNLOAD_THREADS_RESULT, openKDriveIntent)
+                    setBackNavigationResult(DOWNLOAD_MESSAGES_RESULT, openKDriveIntent)
                 } ?: run { findNavController().popBackStack() }
             }
         }
@@ -75,6 +75,6 @@ class DownloadThreadsProgressDialog : DownloadProgressDialog() {
     }
 
     companion object {
-        const val DOWNLOAD_THREADS_RESULT = "download_threads_result"
+        const val DOWNLOAD_MESSAGES_RESULT = "download_messages_result"
     }
 }
diff --git a/...hread/actions/DownloadThreadsViewModel.kt → ...read/actions/DownloadMessagesViewModel.kt b/...hread/actions/DownloadThreadsViewModel.kt → ...read/actions/DownloadMessagesViewModel.kt
@@ -38,7 +38,7 @@ import java.io.File
 import javax.inject.Inject
 
 @HiltViewModel
-class DownloadThreadsViewModel @Inject constructor(
+class DownloadMessagesViewModel @Inject constructor(
     application: Application,
     private val savedStateHandle: SavedStateHandle,
     private val messageController: MessageController,
@@ -48,7 +48,7 @@ class DownloadThreadsViewModel @Inject constructor(
     private val ioCoroutineContext = viewModelScope.coroutineContext(ioDispatcher)
 
     private val messageLocalUids
-        inline get() = savedStateHandle.get<Array<String>>(DownloadThreadsProgressDialogArgs::messageUids.name)!!
+        inline get() = savedStateHandle.get<Array<String>>(DownloadMessagesProgressDialogArgs::messageUids.name)!!
 
     fun downloadThreads(currentMailbox: Mailbox?) = liveData(ioCoroutineContext) {
         val downloadedThreadUris: List<Uri>? = runCatching {
@@ -58,7 +58,7 @@ class DownloadThreadsViewModel @Inject constructor(
 
             messageLocalUids.forEach { messageUid ->
                 val message = messageController.getMessage(messageUid) ?: return@runCatching null
-                val response = ApiRepository.getDownloadedAttachment(mailbox.uuid, message.folderId, message.shortUid)
+                val response = ApiRepository.getDownloadedMessage(mailbox.uuid, message.folderId, message.shortUid)
 
                 if (!response.isSuccessful || response.body == null) return@runCatching null
 

diff --git a/...c/main/java/com/infomaniak/mail/ui/main/thread/actions/MessageActionsBottomSheetDialog.kt b/...c/main/java/com/infomaniak/mail/ui/main/thread/actions/MessageActionsBottomSheetDialog.kt
@@ -177,7 +177,7 @@ class MessageActionsBottomSheetDialog : MailActionsBottomSheetDialog() {
 
             override fun onSaveKDrive() {
                 trackBottomSheetThreadActionsEvent(ACTION_SAVE_KDRIVE_NAME)
-                navigateToDownloadThreadsProgressDialog(
+                navigateToDownloadMessagesProgressDialog(
                     listOf(messageUid),
                     mainViewModel.getSubject(threadUid),
                     MessageActionsBottomSheetDialog::class.java.name

diff --git a/app/src/main/java/com/infomaniak/mail/ui/main/thread/actions/MultiSelectBottomSheetDialog.kt b/app/src/main/java/com/infomaniak/mail/ui/main/thread/actions/MultiSelectBottomSheetDialog.kt
@@ -41,7 +41,7 @@ import com.infomaniak.mail.ui.main.folder.ThreadListMultiSelection
 import com.infomaniak.mail.ui.main.folder.ThreadListMultiSelection.Companion.getReadIconAndShortText
 import com.infomaniak.mail.utils.extensions.animatedNavigation
 import com.infomaniak.mail.utils.extensions.deleteWithConfirmationPopup
-import com.infomaniak.mail.utils.extensions.navigateToDownloadThreadsProgressDialog
+import com.infomaniak.mail.utils.extensions.navigateToDownloadMessagesProgressDialog
 import dagger.hilt.android.AndroidEntryPoint
 import javax.inject.Inject
 
@@ -120,7 +120,7 @@ class MultiSelectBottomSheetDialog : ActionsBottomSheetDialog() {
         }
         binding.saveKDrive.setClosingOnClickListener(shouldCloseMultiSelection = true) {
             trackMultiSelectActionEvent(ACTION_SAVE_KDRIVE_NAME, selectedThreadsCount, isFromBottomSheet = true)
-            navigateToDownloadThreadsProgressDialog(
+            navigateToDownloadMessagesProgressDialog(
                 messageUids = mainViewModel.getMessagesUidsFromThreadUids(selectedThreadsUids),
                 nameFirstMessage = selectedThreads.firstOrNull()?.subject,
                 MultiSelectBottomSheetDialog::class.java.name,

diff --git a/...rc/main/java/com/infomaniak/mail/ui/main/thread/actions/ThreadActionsBottomSheetDialog.kt b/...rc/main/java/com/infomaniak/mail/ui/main/thread/actions/ThreadActionsBottomSheetDialog.kt
@@ -198,7 +198,7 @@ class ThreadActionsBottomSheetDialog : MailActionsBottomSheetDialog() {
 
                 override fun onSaveKDrive() {
                     trackBottomSheetThreadActionsEvent(ACTION_SAVE_KDRIVE_NAME)
-                    navigateToDownloadThreadsProgressDialog(
+                    navigateToDownloadMessagesProgressDialog(
                         messageUids = thread.messages.map { it.uid },
                         nameFirstMessage = thread.subject,
                         ThreadActionsBottomSheetDialog::class.java.name

diff --git a/app/src/main/java/com/infomaniak/mail/utils/extensions/NavigationExtensions.kt b/app/src/main/java/com/infomaniak/mail/utils/extensions/NavigationExtensions.kt
@@ -36,7 +36,7 @@ import com.infomaniak.mail.ui.login.LoginActivity
 import com.infomaniak.mail.ui.login.LoginActivityArgs
 import com.infomaniak.mail.ui.login.NoMailboxActivity
 import com.infomaniak.mail.ui.main.thread.actions.AttachmentActionsBottomSheetDialog
-import com.infomaniak.mail.ui.main.thread.actions.DownloadThreadsProgressDialogArgs
+import com.infomaniak.mail.ui.main.thread.actions.DownloadMessagesProgressDialogArgs
 import com.infomaniak.mail.ui.newMessage.NewMessageActivityArgs
 import com.infomaniak.mail.ui.noValidMailboxes.NoValidMailboxesActivity
 import com.infomaniak.mail.utils.AccountUtils
@@ -91,14 +91,14 @@ fun Fragment.navigateToDownloadProgressDialog(
     )
 }
 
-fun Fragment.navigateToDownloadThreadsProgressDialog(
+fun Fragment.navigateToDownloadMessagesProgressDialog(
     messageUids: List<String>,
     nameFirstMessage: String?,
     currentClassName: String
 ) {
     safeNavigate(
-        resId = R.id.downloadThreadsProgressDialog,
-        args = DownloadThreadsProgressDialogArgs(
+        resId = R.id.downloadMessagesProgressDialog,
+        args = DownloadMessagesProgressDialogArgs(
             messageUids = messageUids.toTypedArray(),
             nameFirstMessage = nameFirstMessage
         ).toBundle(),

diff --git a/app/src/main/res/navigation/main_navigation.xml b/app/src/main/res/navigation/main_navigation.xml
@@ -574,9 +574,9 @@
     </dialog>
 
     <dialog
-        android:id="@+id/downloadThreadsProgressDialog"
-        android:name="com.infomaniak.mail.ui.main.thread.actions.DownloadThreadsProgressDialog"
-        android:label="DownloadThreadsProgressDialog"
+        android:id="@+id/downloadMessagesProgressDialog"
+        android:name="com.infomaniak.mail.ui.main.thread.actions.DownloadMessagesProgressDialog"
+        android:label="DownloadMessagesProgressDialog"
         tools:layout="@layout/dialog_download_progress">
         <argument
             android:name="messageUids"