Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navdrawer updates #465

Merged
merged 8 commits into from
Sep 11, 2017
Merged

Navdrawer updates #465

merged 8 commits into from
Sep 11, 2017

Conversation

damyanpetev
Copy link
Member

@damyanpetev damyanpetev commented Sep 5, 2017

Changes for #447:

Additional information related to this pull request:

  • Rename <ig-nav-drawer> to <igx-nav-drawer> ( ⚠️ )
  • Add active pinThreshold on window resize and two-way bind [(pin)] to go with that.
  • Export IgxNavigationModule from main source. Not sure this is the best way, directives can be merged in the existing module.
  • Drawer closes (when not pinned) when you select a sample
  • Misc cleanup of unused imports

Edit: The active pinThreshold actually introduces another change ( ⚠️ ) as it will override the pin setting. Could remove the default threshold or separate them internally to allow the pin option to override instead?

@coveralls
Copy link

Coverage Status

Coverage increased (+0.05%) to 91.018% when pulling 7274eda on damyanpetev:navdrawer-updates into f4e479a on IgniteUI:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.05%) to 91.018% when pulling 74266df on damyanpetev:navdrawer-updates into f4e479a on IgniteUI:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.05%) to 91.018% when pulling db3b7cf on damyanpetev:navdrawer-updates into f4e479a on IgniteUI:master.

@kdinev kdinev merged commit 4733120 into IgniteUI:master Sep 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants