-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Navdrawer updates #465
Merged
Merged
Navdrawer updates #465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updating samples.
Drop extra aside element
simeonoff
approved these changes
Sep 5, 2017
damyanpetev
force-pushed
the
navdrawer-updates
branch
from
September 5, 2017 14:10
74266df
to
db3b7cf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes for #447:
Additional information related to this pull request:
<ig-nav-drawer>
to<igx-nav-drawer>
(pinThreshold
on window resize and two-way bind[(pin)]
to go with that.IgxNavigationModule
from main source. Not sure this is the best way, directives can be merged in the existing module.Edit: The active⚠️ ) as it will override the pin setting. Could remove the default threshold or separate them internally to allow the
pinThreshold
actually introduces another change (pin
option to override instead?