Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ig-nav-drawer optimizations #447

Closed
IG-Stanimir-Dimitrov opened this issue Aug 10, 2017 · 7 comments
Closed

ig-nav-drawer optimizations #447

IG-Stanimir-Dimitrov opened this issue Aug 10, 2017 · 7 comments
Assignees
Milestone

Comments

@IG-Stanimir-Dimitrov
Copy link
Contributor

Description

The ig-nav-drawer requires some optimization since it was developed on an earlier angular version.

@damyanpetev
Copy link
Member

There seems to be a gestures issue with Hammer.js and Chrome 55+ (works in FF) due to changes to input events. As far as I cant tell pans (touchmove-like) get stuck past the initial trigger and swipes don't get recognized at all (due to pan stopping). Possibly related to hammerjs/hammer.js#1065 and others. Appears to be related to the target as changing the document handlers to body helped.

I see a similar issue with Carousel that uses renderer.listen(this.elementRef.nativeElement, "swipeleft".. and also fails on Chrome (though somehow a similar declarative handler works for the calendar just fine). I've logged #458 for that.

@damyanpetev
Copy link
Member

Since this is a generic task, beyond the fix for gestures I do have some suggestions:

  • Rename <ig-nav-drawer> to <igx-nav-drawer> to align with other components
  • Expose a NavigationModule[NNF] for the nav service and directives or include them in existing modules
  • Use our pre-built animations - that might require our own app container component to work with pinned state, though.
  • A mini-template version in the samples

@IG-Stanimir-Dimitrov , @kdinev thoughts/suggestions?

@IG-Stanimir-Dimitrov
Copy link
Contributor Author

IG-Stanimir-Dimitrov commented Aug 25, 2017

@damyanpetev , I agree on the first three points though some of the animations will be an overkill .
Also update the navDrawer spec in the wiki with the latest changes.

kdinev added a commit that referenced this issue Aug 25, 2017
@damyanpetev
Copy link
Member

@IG-Stanimir-Dimitrov The drawer can have two templates, the mini is a visible collapsed state (e.g. just icons). Last points in the spec stories. The originals samples for component had one, and the new have the ideal icon setup to show that off as well.

@damyanpetev
Copy link
Member

Actually an addition - since pinThreshold is evaluated on init only, it might be a good idea to add a resize handler to make it dynamic?

@IG-Stanimir-Dimitrov
Copy link
Contributor Author

@damyanpetev , I agree - even a basic scenario like a rotating tablet will be handled much better if the pinThreshold is evaluated reactively on resize.

@IG-Stanimir-Dimitrov
Copy link
Contributor Author

IG-Stanimir-Dimitrov commented Sep 21, 2017

This issue was closed with PR #465

@damyanpetev , update specification as well as the readme.md with the changed igx name and new pinThreshold break point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants