-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨♻️ webserver: refactored groups plugin and new user privacy compliance #6917
✨♻️ webserver: refactored groups plugin and new user privacy compliance #6917
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6917 +/- ##
==========================================
- Coverage 88.23% 88.12% -0.11%
==========================================
Files 1579 1577 -2
Lines 61879 61796 -83
Branches 2002 2005 +3
==========================================
- Hits 54596 54460 -136
- Misses 6948 7000 +52
- Partials 335 336 +1
Continue to review full report in Codecov by Sentry.
|
2fb361b
to
ecbc0a3
Compare
:alarm: This will break the frontend. Don't merge it before we release to staging. Users might not want to be reached (added to a group) by email, but will always be able to be added by their |
packages/models-library/src/models_library/api_schemas_webserver/groups.py
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just a bit concerned about the organization. Otherwise all good thanks
packages/models-library/src/models_library/api_schemas_webserver/groups.py
Outdated
Show resolved
Hide resolved
packages/models-library/src/models_library/api_schemas_webserver/groups.py
Outdated
Show resolved
Hide resolved
packages/postgres-database/src/simcore_postgres_database/utils_products.py
Outdated
Show resolved
Hide resolved
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for refactoring!
Q: Is it still valid, that organizations are groups with read access True? |
3e9b78b
to
eb6071d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👌
@matusdrobuliak66 I limited the REST api to do write/delete operations to standard groups. In this sense, "organization" is a front-end concept. Those are standard-groups owned by a user and therefore it can operate on them. The groups associated to a product are indeed standard groups but w/o any access to the users. Therefore these are never provided via the REST api except for a small section in |
Quality Gate passedIssues Measures |
What do these changes do?
This pr includes a major refactoring and new logic regarding privacy settings for the
groups
plugin in the web-server♻️ Refactoring Highlights
to_model
/from_model
) in the schema class.asyncpg
for better performance.pytest_simcore.simcore_webserver_groups_fixtures
.✨ Privacy and Feature Updates
🛠️ Additional Updates
privacy_hide_emai=False
and also the default until 🎨 [Frontend] Enh: users are identified by username #6934 is ready. (@odeimaiz )Related issue/s
How to test
Driving tests
Dev-ops
NOne