-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Fixes web-api: issues on groups entrypoints #6939
🐛 Fixes web-api: issues on groups entrypoints #6939
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6939 +/- ##
==========================================
- Coverage 75.57% 72.14% -3.43%
==========================================
Files 1082 765 -317
Lines 44715 34509 -10206
Branches 909 262 -647
==========================================
- Hits 33794 24898 -8896
+ Misses 10788 9551 -1237
+ Partials 133 60 -73
*This pull request uses carry forward flags. Click here to find out more.
Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice. Thanks a lot. Just a minor suggestion from my side
services/web/server/tests/unit/with_dbs/01/groups/test_groups_handlers_crud.py
Show resolved
Hide resolved
739fad7
to
85ac82e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot!
Quality Gate passedIssues Measures |
What do these changes do?
This PR addresses issues currently present in the master deployment:
add_user_to_group
by properly handlinguserName
.gid
anduid
in the web API OpenAPI Specification (OAS), which is currently blocking front-end operations in master.Related issue/s
How to test
test_list_user_groups_and_try_modify_organizations
Dev-ops
None