Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Fixes web-api: issues on groups entrypoints #6939

Merged
merged 10 commits into from
Dec 11, 2024

Conversation

pcrespov
Copy link
Member

@pcrespov pcrespov commented Dec 11, 2024

What do these changes do?

ReDoc

This PR addresses issues currently present in the master deployment:

  • Resolves the issue with add_user_to_group by properly handling userName.
  • Corrects the incorrect return types for gid and uid in the web API OpenAPI Specification (OAS), which is currently blocking front-end operations in master.
    image

Related issue/s

How to test

  • test_list_user_groups_and_try_modify_organizations

Dev-ops

None

@pcrespov pcrespov self-assigned this Dec 11, 2024
@pcrespov pcrespov added the a:webserver issue related to the webserver service label Dec 11, 2024
@pcrespov pcrespov added this to the Event Horizon milestone Dec 11, 2024
@pcrespov pcrespov changed the title 🐛 Fixes groups api: add-user-group 🐛 Fixes web-api: issues on groups entrypoints Dec 11, 2024
@pcrespov pcrespov marked this pull request as ready for review December 11, 2024 10:00
Copy link
Member

@odeimaiz odeimaiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

Copy link

codecov bot commented Dec 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.14%. Comparing base (7f9f92f) to head (15dd386).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6939      +/-   ##
==========================================
- Coverage   75.57%   72.14%   -3.43%     
==========================================
  Files        1082      765     -317     
  Lines       44715    34509   -10206     
  Branches      909      262     -647     
==========================================
- Hits        33794    24898    -8896     
+ Misses      10788     9551    -1237     
+ Partials      133       60      -73     
Flag Coverage Δ *Carryforward flag
integrationtests 69.69% <ø> (+4.88%) ⬆️ Carriedforward from a35576c
unittests 92.03% <ø> (+17.73%) ⬆️

*This pull request uses carry forward flags. Click here to find out more.

Components Coverage Δ
api ∅ <ø> (∅)
pkg_aws_library ∅ <ø> (∅)
pkg_dask_task_models_library ∅ <ø> (∅)
pkg_models_library ∅ <ø> (∅)
pkg_notifications_library ∅ <ø> (∅)
pkg_postgres_database ∅ <ø> (∅)
pkg_service_integration ∅ <ø> (∅)
pkg_service_library ∅ <ø> (∅)
pkg_settings_library ∅ <ø> (∅)
pkg_simcore_sdk 77.37% <ø> (ø)
agent 97.00% <ø> (ø)
api_server ∅ <ø> (∅)
autoscaling ∅ <ø> (∅)
catalog 90.57% <ø> (ø)
clusters_keeper ∅ <ø> (∅)
dask_sidecar ∅ <ø> (∅)
datcore_adapter 93.18% <ø> (ø)
director ∅ <ø> (∅)
director_v2 78.81% <ø> (+0.01%) ⬆️
dynamic_scheduler ∅ <ø> (∅)
dynamic_sidecar 59.86% <ø> (ø)
efs_guardian 90.12% <ø> (ø)
invitations 93.44% <ø> (ø)
osparc_gateway_server ∅ <ø> (∅)
payments ∅ <ø> (∅)
resource_usage_tracker ∅ <ø> (∅)
storage ∅ <ø> (∅)
webclient ∅ <ø> (∅)
webserver 67.76% <ø> (+2.18%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7f9f92f...15dd386. Read the comment docs.

Copy link
Contributor

@bisgaard-itis bisgaard-itis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice. Thanks a lot. Just a minor suggestion from my side

@pcrespov pcrespov force-pushed the is1779/fixes-master branch from 739fad7 to 85ac82e Compare December 11, 2024 10:31
@pcrespov pcrespov enabled auto-merge (squash) December 11, 2024 10:33
Copy link
Contributor

@matusdrobuliak66 matusdrobuliak66 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

@pcrespov pcrespov disabled auto-merge December 11, 2024 11:37
@pcrespov pcrespov merged commit 92ddd6c into ITISFoundation:master Dec 11, 2024
1 check failed
@pcrespov pcrespov deleted the is1779/fixes-master branch December 11, 2024 11:37
Copy link

sonarcloud bot commented Dec 11, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:webserver issue related to the webserver service
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants