-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨Expiration Date: FE 2nd iteration #3397
✨Expiration Date: FE 2nd iteration #3397
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3397 +/- ##
========================================
+ Coverage 81.8% 85.0% +3.1%
========================================
Files 815 616 -199
Lines 34548 29189 -5359
Branches 1358 1064 -294
========================================
- Hits 28283 24815 -3468
+ Misses 6084 4222 -1862
+ Partials 181 152 -29
Flags with carried forward coverage won't be shown. Click here to find out more. |
Kudos, SonarCloud Quality Gate passed! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great! 🎉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Super! I guess this also solves the negative number days I had yesterday "Your account will expire in -1 day". |
Correct, users will never see the negative number because the backend won't let them in. |
What do these changes do?
Related issue/s
#3352
How to test
Checklist