Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨Expiration Date: FE 2nd iteration #3397

Merged
merged 3 commits into from
Sep 28, 2022

Conversation

odeimaiz
Copy link
Member

@odeimaiz odeimaiz commented Sep 27, 2022

What do these changes do?

  • Backend only provides the expiration DAY. Frontend updated accordingly
  • If accounts expires in less than 7 days:
    • More human readable Flash Message
    • Show hourglass with tooltip in Navigation bar. Tapping it brings you to the preferences

Expire

Related issue/s

#3352

How to test

Checklist

@odeimaiz odeimaiz added the a:frontend issue affecting the front-end (area group) label Sep 27, 2022
@odeimaiz odeimaiz added this to the vaporwave milestone Sep 27, 2022
@odeimaiz odeimaiz self-assigned this Sep 27, 2022
@codecov
Copy link

codecov bot commented Sep 27, 2022

Codecov Report

Merging #3397 (92db53f) into master (bb286b9) will increase coverage by 3.1%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #3397     +/-   ##
========================================
+ Coverage    81.8%   85.0%   +3.1%     
========================================
  Files         815     616    -199     
  Lines       34548   29189   -5359     
  Branches     1358    1064    -294     
========================================
- Hits        28283   24815   -3468     
+ Misses       6084    4222   -1862     
+ Partials      181     152     -29     
Flag Coverage Δ
integrationtests 68.6% <ø> (+16.4%) ⬆️
unittests 81.2% <ø> (+1.3%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ore_service_director_v2/utils/dask_client_utils.py 81.7% <0.0%> (-5.3%) ⬇️
...ector_v2/modules/dynamic_sidecar/scheduler/task.py 83.4% <0.0%> (-0.8%) ⬇️
...tor_v2/modules/dynamic_sidecar/docker_api/_core.py 96.5% <0.0%> (-0.5%) ⬇️
...tor_v2/modules/dynamic_sidecar/scheduler/_utils.py 89.6% <0.0%> (ø)
...mcore_service_catalog/api/dependencies/database.py
...ling/src/simcore_service_autoscaling/api/routes.py
...rc/simcore_service_api_server/modules/webserver.py
.../src/simcore_service_api_server/api/routes/meta.py
...s/api-server/src/simcore_service_api_server/cli.py
...ore_service_api_server/db/repositories/__init__.py
... and 222 more

@odeimaiz odeimaiz marked this pull request as ready for review September 27, 2022 14:22
@sonarcloud
Copy link

sonarcloud bot commented Sep 27, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@odeimaiz odeimaiz changed the title expirationDate is only date, no time ✨Expiration Date: FE 2nd iteration Sep 27, 2022
Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great! 🎉

Copy link
Contributor

@GitHK GitHK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@elisabettai
Copy link
Collaborator

Super! I guess this also solves the negative number days I had yesterday "Your account will expire in -1 day".
Minor suggestion: when the account has expired, I would add the support email in the flash message.

@odeimaiz odeimaiz merged commit 3033106 into ITISFoundation:master Sep 28, 2022
@odeimaiz
Copy link
Member Author

Super! I guess this also solves the negative number days I had yesterday "Your account will expire in -1 day". Minor suggestion: when the account has expired, I would add the support email in the flash message.

Correct, users will never see the negative number because the backend won't let them in.
The support email is already part of the Flash Message and also the tooltips 👌. But, if the log in fails because the account expired, the frontend just shows the error message coming from the backend. Therefore, the support email has to be added in the backend. I can take care of that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:frontend issue affecting the front-end (area group)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants