Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ FE various: support email on expired message, Enter key linked to validate button and blink Output in App Mode #3400

Merged
merged 14 commits into from
Sep 30, 2022

Conversation

odeimaiz
Copy link
Member

@odeimaiz odeimaiz commented Sep 29, 2022

What do these changes do?

  • When the account has expired, add the support email in the flash message.
  • Validate SMS form: Enter key linked to Validate button
  • App mode: make Output icon/button blink when a new output is pushed
  • e2e fixes

Error with support email
support

Blinking "Outputs"
Output_blink

Related issue/s

Support email added: #3397 (comment)

How to test

Checklist

@odeimaiz odeimaiz self-assigned this Sep 29, 2022
@codecov
Copy link

codecov bot commented Sep 29, 2022

Codecov Report

Merging #3400 (1b27287) into master (65a95cd) will decrease coverage by 4.9%.
The diff coverage is 100.0%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #3400      +/-   ##
=========================================
- Coverage    88.1%   83.1%    -5.0%     
=========================================
  Files         380     816     +436     
  Lines       19106   34586   +15480     
  Branches      162    1362    +1200     
=========================================
+ Hits        16833   28750   +11917     
- Misses       2227    5655    +3428     
- Partials       46     181     +135     
Flag Coverage Δ
integrationtests 68.6% <77.7%> (+<0.1%) ⬆️
unittests 79.9% <100.0%> (-3.9%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...er/src/simcore_service_webserver/login/handlers.py 86.6% <100.0%> (+<0.1%) ⬆️
...rver/src/simcore_service_webserver/login/plugin.py 92.4% <100.0%> (+0.2%) ⬆️
...er/src/simcore_service_webserver/login/settings.py 100.0% <100.0%> (ø)
...rvice_dynamic_sidecar/core/docker_compose_utils.py 95.9% <0.0%> (ø)
...ce_catalog/models/domain/service_specifications.py 100.0% <0.0%> (ø)
...icelib/aiohttp/long_running_tasks/_dependencies.py 100.0% <0.0%> (ø)
...-sidecar/src/simcore_service_dask_sidecar/utils.py 100.0% <0.0%> (ø)
...-library/src/servicelib/aiohttp/rest_validators.py 90.6% <0.0%> (ø)
.../settings-library/src/settings_library/postgres.py 86.8% <0.0%> (ø)
...vice-library/src/servicelib/aiohttp/aiopg_utils.py 91.9% <0.0%> (ø)
... and 440 more

@odeimaiz odeimaiz added this to the vaporwave milestone Sep 29, 2022
@odeimaiz odeimaiz marked this pull request as ready for review September 29, 2022 13:53
@odeimaiz odeimaiz changed the title ✨ minors ✨ FE minors Sep 29, 2022
Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉
Please make the issue title more descriptive. It will facilitate the work of @elisabettai for the changelogs upon release

@odeimaiz odeimaiz changed the title ✨ FE minors ✨ FE various: support email on expired message, Enter key linked to validate button and blink Output in App Mode Sep 29, 2022
Copy link
Collaborator

@elisabettai elisabettai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔦

@odeimaiz odeimaiz added a:frontend issue affecting the front-end (area group) changelog:🎨enhancement labels Sep 29, 2022
Copy link
Contributor

@GitHK GitHK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@sonarcloud
Copy link

sonarcloud bot commented Sep 30, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@odeimaiz odeimaiz merged commit 5fd5898 into ITISFoundation:master Sep 30, 2022
@odeimaiz odeimaiz deleted the fix/missing-links branch September 30, 2022 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:frontend issue affecting the front-end (area group)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants