Is677/trial account

[pcrespov]

What do these changes do?

A user account can have an expiration date. Expired users access is blocked with 401.

packages/postgres-database

• ✨ users.expires_at column used for account expiration.
• 📝 updates doc of users table
• ✨ periodic task checks for expired users
• 🐛 fixes wrong openapi specs

services/web/server

• ✨ Requests from users marked as EXPIRED are errored with 401 and MSG_USER_EXPIRED
• ✨ pydantic models to validate openapi schemas for users entrypoint
  • `users_models``: mainly Profile-like models
  • `groups_models`` currently only used in Profile. groups API entrypoints are still not using these models. Will follow up with Use new models in groups plugin #3361
• ✨ periodic task (launched in the garbage-collector plugin) updates the users table looking for expired accounts.

⚠️ devops

• new environment variable to update trial accounts: GARBAGE_COLLECTOR_EXPIRED_USERS_CHECK_INTERVAL_S (defaults to 6h interval)

Related issue/s

• Implements part of Trial account osparc-issues#677

How to test

pytest -v tests/**/test_users*.py

Checklist

• Openapi changes? make openapi-specs, git commit ... and then make version-*)
• Database migration script? cd packages/postgres-database, make setup-commit, sc-pg review -m "my changes"
• Unit tests for the changes exist
• Runs in the swarm
• Documentation reflects the changes
• New module? Add your github username to .github/CODEOWNERS

[codecov]

Codecov Report

Merging #3352 (1bf7818) into master (ecb8b35) will increase coverage by 0.0%.
The diff coverage is 97.0%.

@@           Coverage Diff           @@
##           master   #3352    +/-   ##
=======================================
  Coverage    83.0%   83.0%            
=======================================
  Files         808     811     +3     
  Lines       34261   34410   +149     
  Branches     1358    1358            
=======================================
+ Hits        28437   28593   +156     
+ Misses       5643    5636     -7     
  Partials      181     181            

Flag	Coverage Δ
integrationtests	68.7% <83.0%> (+0.3%)	⬆️
unittests	79.8% <97.0%> (+<0.1%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...erver/src/simcore_service_webserver/users_utils.py	90.0% <80.0%> (-10.0%)	⬇️
.../server/src/simcore_service_webserver/users_api.py	95.1% <88.8%> (-1.2%)	⬇️
...service_webserver/users_garbage_collector_tasks.py	95.5% <95.5%> (ø)
...rver/src/simcore_service_webserver/users_models.py	97.6% <97.6%> (ø)
...s/models-library/src/models_library/basic_types.py	96.5% <100.0%> (+0.1%)	⬆️
...base/src/simcore_postgres_database/models/users.py	93.3% <100.0%> (+0.2%)	⬆️
...src/simcore_service_webserver/garbage_collector.py	100.0% <100.0%> (ø)
...re_service_webserver/garbage_collector_settings.py	100.0% <100.0%> (ø)
...ver/src/simcore_service_webserver/groups_models.py	100.0% <100.0%> (ø)
...er/src/simcore_service_webserver/login/handlers.py	87.1% <100.0%> (+0.1%)	⬆️
... and 15 more

[sanderegg]

great!, some minor comments, thanks !

[sanderegg]

minor: does it make sense to create first the dictionary and then right away the pydantic model?

[pcrespov]

we are composing a dict and then using the model to validate the entire structure.
If we would have the user_profile in one go I would definitively use the model constructor but it is not the case.

[sanderegg]

minor: why not using the parse_body_as method? it works beautifully.

[pcrespov]

parse_body_as will create a tmp model and include the model class as __root__ and the it calls model.parse_obj. That is handy when you have classes not derived from BaseModel. If your class is derived from BaseModel calling the free function is a unnecessary overhead.

If you do not understand what I mean, just check the implementation
https://github.com/pydantic/pydantic/blob/main/pydantic/tools.py#L38

[GitHK]

👍 Please have look at my questions below

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication