676 libms commander error on windows #888

nichlaes · 2024-08-23T13:08:26Z

No description provided.

uncommented http tests

Uncommented pm2 installment

….com/INTO-CPS-Association/DTaaS into 676-libms-commander-error-on-windows

codecov-commenter · 2024-08-23T13:10:05Z

Codecov Report

Attention: Patch coverage is 0% with 8 lines in your changes missing coverage. Please review.

Project coverage is 0.00%. Comparing base (eaa22d5) to head (d359c6d).
Report is 25 commits behind head on feature/distributed-demo.

❗ Current head d359c6d differs from pull request most recent head 05d0f01

Please upload reports for the commit 05d0f01 to get more accurate results.

Files with missing lines	Patch %	Lines
servers/lib/src/cloudcmd/cloudcmd.ts	0.00%	6 Missing and 1 partial ⚠️
...vers/lib/src/files/services/local-files.service.ts	0.00%	1 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (eaa22d5) and HEAD (d359c6d). Click for more details.

HEAD has 1 upload less than BASE

Flag BASE (eaa22d5) HEAD (d359c6d)

client-unit-integration-tests 1 0

Additional details and impacted files

@@                     Coverage Diff                      @@
##           feature/distributed-demo    #888       +/-   ##
============================================================
- Coverage                     66.49%   0.00%   -66.50%     
============================================================
  Files                            31       6       -25     
  Lines                           394     107      -287     
  Branches                         26       3       -23     
============================================================
- Hits                            262       0      -262     
+ Misses                          117     104       -13     
+ Partials                         15       3       -12

Files with missing lines	Coverage Δ
...vers/lib/src/files/services/local-files.service.ts	`0.00% <0.00%> (ø)`
servers/lib/src/cloudcmd/cloudcmd.ts	`0.00% <0.00%> (ø)`

... and 34 files with indirect coverage changes

Components	Coverage Δ
Website	`∅ <ø> (∅)`
Lib Microservice	`0.00% <ø> (∅)`

prasadtalasila · 2024-08-23T13:31:39Z

@nichlaes Please consider the following suggestions:

Bump up the version code at patch-level (new version is 0.4.6)
Check the functioning of pm2-specific yarn commands both on Windows and Linux
Update the documentation in admin/servers/lib.
There is a docker compose for libms but the matching documentation is missing in README.md and DEVELOPER.md. Please see in client for an example.
Check the functioning of docker compose on Windows and Linux OS platforms

servers/lib/DEVELOPER.md

servers/lib/README.md

prasadtalasila

@nichlaes
Please change CloudCMD word to CloudCMD (an npm package dependency)

prasadtalasila · 2024-08-27T04:05:44Z

@nichlaes
It might be possible to consider the path given, host operating system and then convert the path to relative one on Windows.
This formatting would fix the error on Windows.
Please let me know if this is the right way to proceed.

This reverts commit f423c56.

This reverts commit 11b82d8.

prasadtalasila · 2024-09-03T16:03:41Z

@nichlaes I get the following error.

$yarn build
yarn run v1.22.19
$ npx tsc
                                                                               
                This is not the tsc command you are looking for                
                                                                               

To get access to the TypeScript compiler, tsc, from the command line either:

- Use npm install typescript to first add TypeScript to your project before using npx
- Use yarn to avoid accidentally running code from un-installed packages
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

$yarn add typescript

$ yarn build
yarn run v1.22.19
$ npx tsc
Done in 3.65s.

This did not happen before. Do you know why?

servers/lib/DEVELOPER.md

This reverts commit 89418d8.

prasadtalasila · 2024-09-11T11:31:03Z

@nichlaes are you also addressing issue #482 here?

prasadtalasila

@nichlaes please see the comments. Thanks.

prasadtalasila · 2024-09-11T11:59:53Z

servers/lib/package.json

    "clean": "npx rimraf build node_modules coverage dist src.svg test.svg",
    "format": "prettier --ignore-path ../.gitignore --write \"**/*.{ts,tsx,css,scss}\"",
    "graph": "npx madge --image src.svg src && npx madge --image test.svg test",
    "start": "node dist/src/main.js",
    "start:pm2": "pm2 start pm2.config.js",
    "stop:pm2": "pm2 delete libms",
-    "syntax": "npx eslint . --fix",
+    "syntax": "eslint . --fix",
    "pretest": "npx shx cp test/data/user2/tools/README.md ../../files/user2/tools/README.md",
    "posttest": "npx rimraf ../../files/user2/tools/README.md",
    "test:all": "npx cross-env LOCAL_PATH=test/data jest --testPathIgnorePatterns=cloudcmd --coverage",
    "test:e2e": "npx cross-env LOCAL_PATH=test/data jest --config ./test/jest-e2e.json --coverage",
    "test:http": "yarn build && pm2 start -f --name libms-test dist/src/main.js -- -c .env -H ./config/http.json && jest test/cloudcmd --coverage --coverageThreshold=\"{}\" && pm2 delete libms-test",


This command, when executed on git-bash of Windows 11, is giving the following error.

$ yarn test:http yarn run v1.22.19 $ yarn build && pm2 start -f --name libms-test dist/src/main.js -- -c .env -H ./config/http.json && jest test/cloudcmd --coverage --coverageThreshold="{}" && pm2 delete libms-test $ tsc [PM2] Starting C:\Users\au598657\git\DTaaS\servers\lib\dist\src\main.js in fork_mode (1 instance) [PM2] Done. ┌────┬───────────────┬─────────────┬─────────┬─────────┬──────────┬────────┬──────┬───────────┬──────────┬──────────┬──────────┬──────────┐ │ id │ name │ namespace │ version │ mode │ pid │ uptime │ ↺ │ status │ cpu │ mem │ user │ watching │ ├────┼───────────────┼─────────────┼─────────┼─────────┼──────────┼────────┼──────┼───────────┼──────────┼──────────┼──────────┼──────────┤ │ 0 │ libms-test │ default │ 0.4.6 │ fork │ 28440 │ 0s │ 0 │ online │ 9.3% │ 54.8mb │ au598657 │ disabled │ └────┴───────────────┴─────────────┴─────────┴─────────┴──────────┴────────┴──────┴───────────┴──────────┴──────────┴──────────┴──────────┘ console.log { path: '/', files: [ { name: 'common', size: '0b', date: '08.04.2024', owner: 0, mode: 'rw- rw- rw-', type: 'directory' }, { name: 'template', size: '0b', date: '18.06.2024', owner: 0, mode: 'rw- rw- rw-', type: 'directory' }, { name: 'user1', size: '0b', date: '11.12.2023', owner: 0, mode: 'rw- rw- rw-', type: 'directory' }, { name: 'user2', size: '0b', date: '11.12.2023', owner: 0, mode: 'rw- rw- rw-', type: 'directory' }, { name: 'README.md', size: '180b', date: '11.12.2023', owner: 0, mode: 'rw- rw- rw-', type: 'file' }, { name: 'test.txt', size: '12b', date: '11.09.2024', owner: 0, mode: 'rw- rw- rw-', type: 'file' } ] } at Object.<anonymous> (test/cloudcmd/cloudcmd.spec.ts:27:13) PASS test/cloudcmd/cloudcmd.spec.ts (10.616 s) cloudcmd test for the application √ should return the correct directory that is set as root (103 ms) √ should return the content of a file that is uplaoded to cloudcmd (5 ms) √ should upload a file to cloudcmd (30 ms) ---------------------------|---------|----------|---------|---------|------------------- File | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s ---------------------------|---------|----------|---------|---------|------------------- All files | 0 | 0 | 0 | 0 | src | 0 | 0 | 0 | 0 | bootstrap.ts | 0 | 0 | 0 | 0 | 1-36 types.ts | 0 | 100 | 0 | 0 | 1-91 src/cloudcmd | 0 | 0 | 0 | 0 | cloudcmd.ts | 0 | 0 | 0 | 0 | 2-40 src/files | 0 | 100 | 100 | 0 | files.module.ts | 0 | 100 | 100 | 0 | 1-9 src/files/resolvers | 0 | 100 | 0 | 0 | files.resolver.ts | 0 | 100 | 0 | 0 | 1-21 src/files/services | 0 | 0 | 0 | 0 | files-service.factory.ts | 0 | 0 | 0 | 0 | 1-20 local-files.service.ts | 0 | 0 | 0 | 0 | 1-62 ---------------------------|---------|----------|---------|---------|------------------- Test Suites: 1 passed, 1 total Tests: 3 passed, 3 total Snapshots: 0 total Time: 17.925 s Ran all test suites matching /test\\cloudcmd/i. [PM2] Applying action deleteProcessId on app [libms-test](ids: [ 0 ]) [PM2] [libms-test](0) ✓ ┌────┬───────────┬─────────────┬─────────┬─────────┬──────────┬────────┬──────┬───────────┬──────────┬──────────┬──────────┬──────────┐ │ id │ name │ namespace │ version │ mode │ pid │ uptime │ ↺ │ status │ cpu │ mem │ user │ watching │ └────┴───────────┴─────────────┴─────────┴─────────┴──────────┴────────┴──────┴───────────┴──────────┴──────────┴──────────┴──────────┘ Done in 22.34s.

@nichlaes has problem been resolved?

@prasadtalasila Is that an error? Is it not just the console.log?

servers/lib/package.json

servers/lib/README.md

prasadtalasila · 2024-09-12T20:35:04Z

@nichlaes is this PR complete?

prasadtalasila

@nichlaes thanks for the updates. Please see the comments.

.github/workflows/lib-ms.yml

servers/lib/DEVELOPER.md

servers/lib/README.md

servers/lib/compose.lib.dev.yml

prasadtalasila · 2024-09-13T13:10:34Z

servers/lib/package.json

    "clean": "npx rimraf build node_modules coverage dist src.svg test.svg",
    "format": "prettier --ignore-path ../.gitignore --write \"**/*.{ts,tsx,css,scss}\"",
    "graph": "npx madge --image src.svg src && npx madge --image test.svg test",
    "start": "node dist/src/main.js",
    "start:pm2": "pm2 start pm2.config.js",
    "stop:pm2": "pm2 delete libms",
-    "syntax": "npx eslint . --fix",
+    "syntax": "eslint . --fix",
    "pretest": "npx shx cp test/data/user2/tools/README.md ../../files/user2/tools/README.md",
    "posttest": "npx rimraf ../../files/user2/tools/README.md",
    "test:all": "npx cross-env LOCAL_PATH=test/data jest --testPathIgnorePatterns=cloudcmd --coverage",
    "test:e2e": "npx cross-env LOCAL_PATH=test/data jest --config ./test/jest-e2e.json --coverage",
    "test:http": "yarn build && pm2 start -f --name libms-test dist/src/main.js -- -c .env -H ./config/http.json && jest test/cloudcmd --coverage --coverageThreshold=\"{}\" && pm2 delete libms-test",


@nichlaes has problem been resolved?

servers/lib/DEVELOPER.md

codeclimate · 2024-09-16T13:06:25Z

Code Climate has analyzed commit 05d0f01 and detected 0 issues on this pull request.

View more on Code Climate.

nichlaes and others added 6 commits August 20, 2024 10:11

changes test to be independent of the files order

31493e2

Update lib-ms.yml

5f3273e

uncommented http tests

Update lib-ms.yml

a3c0d83

Uncommented pm2 installment

adds windows path restraint

11b82d8

Merge branch '676-libms-commander-error-on-windows' of https://github…

8c4f5ef

….com/INTO-CPS-Association/DTaaS into 676-libms-commander-error-on-windows

commented out failing tests on action

89418d8

nichlaes requested a review from prasadtalasila August 23, 2024 13:08

nichlaes linked an issue Aug 23, 2024 that may be closed by this pull request

libms: commander error on Windows #676

Closed

nichlaes added 2 commits August 26, 2024 11:04

bumped version to 0.4.6

68ee7c3

adds docker compose to docs

36a6e3c

codeclimate bot reviewed Aug 26, 2024

View reviewed changes

servers/lib/DEVELOPER.md Outdated Show resolved Hide resolved

servers/lib/README.md Outdated Show resolved Hide resolved

nichlaes added 2 commits August 26, 2024 13:20

windows path needs to be relative

f423c56

lint fixes

acc3798

prasadtalasila reviewed Aug 26, 2024

View reviewed changes

nichlaes added 3 commits September 2, 2024 14:23

Revert "windows path needs to be relative"

fb7ded8

This reverts commit f423c56.

Revert "adds windows path restraint"

1e3dba1

This reverts commit 11b82d8.

adds absolute path support for windows

5b95d9c

nichlaes added 3 commits September 4, 2024 09:58

updated packages

587d14d

fixed lint errors

d0e0e71

adds cases for cloudCMD and pm2

e383420

codeclimate bot reviewed Sep 9, 2024

View reviewed changes

servers/lib/DEVELOPER.md Outdated Show resolved Hide resolved

nichlaes added 3 commits September 9, 2024 11:03

fixed linting

b49264f

Revert "commented out failing tests on action"

32360de

This reverts commit 89418d8.

adds delay for server to get ready when running on github

3e33a08

increased sleep

229a403

prasadtalasila reviewed Sep 11, 2024

View reviewed changes

nichlaes added 12 commits September 11, 2024 15:42

error only if env are not set

3bf3a49

changed test url

c25dfc3

verify url works

632cf1d

testing tests

69e97c8

tests without pm2

a6dde57

installs jest

0e39a8c

.

b329235

changed port and order

ce7ce03

changed order

e858e5f

ignores bootstrap.ts

d98549a

fixed deprecated func

ea69a01

removes temp tests

15d3745

adds check for server running

d359c6d

prasadtalasila reviewed Sep 13, 2024

View reviewed changes

nichlaes added 2 commits September 16, 2024 10:15

set working directory

18326ee

updated docs

7a9a2aa

codeclimate bot reviewed Sep 16, 2024

View reviewed changes

servers/lib/DEVELOPER.md Outdated Show resolved Hide resolved

code climate fix

182e8cb

codeclimate bot reviewed Sep 16, 2024

View reviewed changes

servers/lib/DEVELOPER.md Outdated Show resolved Hide resolved

nichlaes added 2 commits September 16, 2024 13:42

removes console log

f33f257

adds local compose file

5f8368f

codeclimate bot reviewed Sep 16, 2024

View reviewed changes

servers/lib/DEVELOPER.md Outdated Show resolved Hide resolved

nichlaes and others added 2 commits September 16, 2024 13:59

specify code block language

0b555a3

Improves DEVELOPER.md

05d0f01

prasadtalasila merged commit 5be6bb2 into feature/distributed-demo Sep 16, 2024
12 checks passed

prasadtalasila mentioned this pull request Sep 16, 2024

tests for http mode of libms fail #482

Closed

prasadtalasila deleted the 676-libms-commander-error-on-windows branch September 23, 2024 12:36

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

676 libms commander error on windows #888

676 libms commander error on windows #888

nichlaes commented Aug 23, 2024

codecov-commenter commented Aug 23, 2024 •

edited by codecov bot

Loading

prasadtalasila commented Aug 23, 2024

prasadtalasila left a comment •

edited

Loading

prasadtalasila commented Aug 27, 2024

prasadtalasila commented Sep 3, 2024

prasadtalasila commented Sep 11, 2024

prasadtalasila left a comment

prasadtalasila Sep 11, 2024

prasadtalasila Sep 13, 2024

nichlaes Sep 16, 2024 •

edited

Loading

prasadtalasila commented Sep 12, 2024

prasadtalasila left a comment

prasadtalasila Sep 13, 2024

codeclimate bot commented Sep 16, 2024

676 libms commander error on windows #888

676 libms commander error on windows #888

Conversation

nichlaes commented Aug 23, 2024

codecov-commenter commented Aug 23, 2024 • edited by codecov bot Loading

Codecov Report

prasadtalasila commented Aug 23, 2024

prasadtalasila left a comment • edited Loading

Choose a reason for hiding this comment

prasadtalasila commented Aug 27, 2024

prasadtalasila commented Sep 3, 2024

prasadtalasila commented Sep 11, 2024

prasadtalasila left a comment

Choose a reason for hiding this comment

prasadtalasila Sep 11, 2024

Choose a reason for hiding this comment

prasadtalasila Sep 13, 2024

Choose a reason for hiding this comment

nichlaes Sep 16, 2024 • edited Loading

Choose a reason for hiding this comment

prasadtalasila commented Sep 12, 2024

prasadtalasila left a comment

Choose a reason for hiding this comment

prasadtalasila Sep 13, 2024

Choose a reason for hiding this comment

codeclimate bot commented Sep 16, 2024

codecov-commenter commented Aug 23, 2024 •

edited by codecov bot

Loading

prasadtalasila left a comment •

edited

Loading

nichlaes Sep 16, 2024 •

edited

Loading