Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests for http mode of libms fail #482

Closed
prasadtalasila opened this issue Jan 27, 2024 · 3 comments
Closed

tests for http mode of libms fail #482

prasadtalasila opened this issue Jan 27, 2024 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@prasadtalasila
Copy link
Contributor

PR #480 adds http mode to library microservice. The following yarn commands run on developer computer but fail on the github actions.

yarn test:http
yarn test:http-nocov
yarn test:http-github

These tests require libms to be running. The libms is launched and terminated on the developer computer using pm2 npm package. But this launch is failing in github actions.

@prasadtalasila prasadtalasila added the bug Something isn't working label Jan 27, 2024
@prasadtalasila prasadtalasila added this to the Release v0.6.0 milestone Jun 19, 2024
@prasadtalasila prasadtalasila moved this from Backlog to In progress in Digital Twin as a Service Aug 12, 2024
@nichlaes
Copy link
Collaborator

@prasadtalasila
Copy link
Contributor Author

@nichlaes
Unfortunately not. The github actions uses test:all which ignores HTTP tests. The HTTP tests are in test/cloudcmd. The following commands of package.json should work in github actions.

    "test:http": "yarn build && pm2 start -f --name libms-test dist/src/main.js -- -c .env -H ./config/http.json && jest test/cloudcmd --coverage --coverageThreshold=\"{}\" && pm2 delete libms-test",
    "test:http-github": "yarn build && yarn start:pm2 && jest test/cloudcmd --coverage --coverageThreshold=\"{}\" && pm2 delete libms",

These commands are commented out in github actions file. The actions must work even when the lines are uncommented.

@prasadtalasila
Copy link
Contributor Author

PR #888 fixes this problem

@github-project-automation github-project-automation bot moved this from In progress to Done in Digital Twin as a Service Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

No branches or pull requests

2 participants