Playwright e2e reconfiguration #871

atomicgamedeveloper · 2024-07-30T18:55:35Z

Resolving issues #45 and #320 regarding the e2e tests using playwright needing to be setup, mitigating issues about gitlab's CAPTCHA's and missing CodeCov in git actions for e2e tests.

…developer/DTaaS into 320-failing-e2e-tests

…2e cmd, rm relative paths

prasadtalasila · 2024-08-27T13:22:23Z

@atomicgamedeveloper Thanks for the PR. Please update the README as well.

prasadtalasila · 2024-08-29T11:16:48Z

@atomicgamedeveloper please rebase to the latest commit on feature/distributed-demo branch

prasadtalasila

@atomicgamedeveloper thanks for the PR. Please check the comments.

prasadtalasila · 2024-08-29T16:31:26Z

client/test/e2e/setup/mcr.config.ts

+const coverageOptions: CoverageReportOptions = {
+  name: 'Playwright Monocart Coverage Report',
+
+  reports: ['codecov', 'v8'],


please add 'console-summary' as well

client/package.json

client/playwright.config.ts

client/test/e2e/tests/auth.setup.ts

codeclimate · 2024-09-05T18:03:21Z

client/test/README.md

+can run the tests by running `yarn test:e2e`.
+
+By default, Playwright launches the react client website as specified in `config/test.js`
+and terminates it afterwards. Running `yarn test:e2e:int` allows you to skip this so


Line length

codeclimate · 2024-09-05T18:03:21Z

client/test/README.md

 ```

 ## OAuth Setup

-You can follow the instructions in
-[authorization page](../../docs/admin/client/auth.md) to setup oauth for the
+You can follow the instructions in [authorization page](../../docs/admin/client/auth.md) to setup OAuth for the


Line length

codeclimate · 2024-09-05T18:03:21Z

client/test/README.md

@@ -35,8 +39,7 @@ the details of your testing environment. For instance, you need to adjust:
 * `REACT_APP_LOGOUT_REDIRECT_URI`

 to reflect your test setup. More information on about the environment settings is
-available in [authorization](../../docs/admin/client/auth.md) and
-[client deployment](../../docs/admin/client/CLIENT.md) pages.
+available in [authorization](../../docs/admin/client/auth.md) and [client deployment](../../docs/admin/client/CLIENT.md) pages.


Line length

codeclimate · 2024-09-05T18:03:21Z

client/test/README.md

@@ -48,6 +51,8 @@ REACT_APP_REDIRECT_URI="http://localhost:4000/Library"
 REACT_APP_LOGOUT_REDIRECT_URI="http://localhost:4000"
 ```

+Finally, run `yarn config:test` to copy the config file into the `build` and `public` folders.


Line length

codeclimate · 2024-09-05T18:03:21Z

client/test/README.md


 ```bash
 yarn test:e2e
 ```
+Or with manual website launch:
+```bash


Fenced code blocks should be surrounded by blank lines

prasadtalasila

@atomicgamedeveloper thanks for the update. Please see the comments.

prasadtalasila · 2024-09-05T19:06:08Z

.github/workflows/client.yml

@@ -8,13 +8,14 @@ on:
    paths:
      - 'client/**'
  workflow_dispatch:
-    paths:


Please keep this. Otherwise, this workflow runs too many times.

.github/workflows/client.yml

prasadtalasila · 2024-09-05T19:13:36Z

client/test/README.md

+
+By default, Playwright launches the react client website as specified in `config/test.js`
+and terminates it afterwards. Running `yarn test:e2e:int` allows you to skip this so
+you can host the website yourself.


Does this mean that we can host the client at a doman address (say sandbox.cps.digit.au.dk) and perform E2E tests?

client/test/README.md

prasadtalasila · 2024-09-06T13:21:44Z

@atomicgamedeveloper Thanks for updates on the PR. List of pending changes:

Rename "int" and "Int" strings with "ext" and "Ext" strings respectively in the playwright.config.js.
Change monocart report output from "console-summary" to "console-detail"
Resolve code conflicts

A quick question on the yarn test:e2e:ext command. To run this test successfully, I ran the following commands in sequence.

# update config/test.js
# Add test/.env file

yarn install
yarn build
yarn config:test
yarn test:e2e:ext

My question is the need to perform build and config:test tasks if we are not running the client website ourselves. Is there a simple way to skip these two steps for the case of externally hosted client? Thanks for the clarification.

prasadtalasila · 2024-09-07T06:31:26Z

@atomicgamedeveloper please increment the packqge version number to 0.4.1.

atomicgamedeveloper · 2024-09-18T15:25:50Z

@atomicgamedeveloper Thanks for updates on the PR. List of pending changes:
1. Rename "int" and "Int" strings with "ext" and "Ext" strings respectively in the playwright.config.js.

2. Change monocart report output from "console-summary" to "console-detail"

3. Resolve code conflicts
A quick question on the yarn test:e2e:ext command. To run this test successfully, I ran the following commands in sequence.
# update config/test.js
# Add test/.env file

yarn install
yarn build
yarn config:test
yarn test:e2e:ext
My question is the need to perform build and config:test tasks if we are not running the client website ourselves. Is there a simple way to skip these two steps for the case of externally hosted client? Thanks for the clarification.

Build and config:test are indeed not necessary for the case of the externally hosted client unless you are using yarn start from within the project, as Playwright draws the app URL from the test/.env anyway. I have updated the README.md to reflect this better.

prasadtalasila · 2024-09-19T15:09:32Z

@atomicgamedeveloper

Test setup:

The tests on the external server are not running successfully for the following setup.

DTaaS server: dtl-server-2.st.lab.au.dk
gitlab: maestro.cps.digit.au.dk/gitlab
(please use your account credentials for this installation)

The logs on my machine are:

PS C:\Users\user\git\DTaaS\client> yarn install
yarn install v1.22.19
[1/4] Resolving packages...
[2/4] Fetching packages...
[3/4] Linking dependencies...
warning Workspaces can only be enabled in private projects.
[4/4] Building fresh packages...
Done in 95.49s.
PS C:\Users\user\git\DTaaS\client> yarn test:e2e:ext
yarn run v1.22.19
$ cross-env ext=true yarn test:e2e
$ playwright test -c ./playwright.config.ts

Running 11 tests using 4 workers

  ✘  1 [setup] › auth.setup.ts:12:1 › authenticate (1.0m)
[MCR] Not found coverage data in dir(s): 


  1) [setup] › auth.setup.ts:12:1 › authenticate ───────────────────────────────────────────────────

    Test timeout of 60000ms exceeded.

    Error: locator.click: Test timeout of 60000ms exceeded.
    Call log:
      - waiting for getByRole('button', { name: 'GitLab logo Sign In with GitLab' })


      15 |   await page
      16 |     .getByRole('button', { name: 'GitLab logo Sign In with GitLab' })
    > 17 |     .click();
         |      ^
      18 |   try {
      19 |     await page.waitForSelector('label[for="user_login"]', { timeout: 10000 }); // wait up to 10 seconds
      20 |   } catch (error) {

        at C:\Users\au598657\git\DTaaS\client\test\e2e\tests\auth.setup.ts:17:6

    attachment #1: trace (application/zip) ─────────────────────────────────────────────────────────
    test-results\auth.setup.ts-authenticate-setup\trace.zip
    Usage:

        yarn playwright show-trace test-results\auth.setup.ts-authenticate-setup\trace.zip

    ────────────────────────────────────────────────────────────────────────────────────────────────

  Slow test file: [setup] › auth.setup.ts (1.0m)
  Consider splitting slow test files to speed up parallel execution
  1 failed
    [setup] › auth.setup.ts:12:1 › authenticate ────────────────────────────────────────────────────
  10 did not run

  Serving HTML report at http://localhost:9323. Press Ctrl+C to quit.
Terminate batch job (Y/N)? Y

Text Corrections

The yarn install and yarn config:test need to be run before yarn test:ext can be run successfully. Please mention this in test/README.md

The DEVELOPER.md has the following text which can be removed.

:bug: The end-to-end tests are extremely brittle.
They are not being used at present.

client/test/README.md

codeclimate · 2024-09-20T11:45:17Z

Code Climate has analyzed commit b4abc81 and detected 0 issues on this pull request.

View more on Code Climate.

Reconfigure playwright, fix tests, update test:e2e and .gitignore

d85490a

atomicgamedeveloper changed the title ~~Reconfigure playwright, fix tests, update test:e2e and .gitignore~~ Playwright e2e reconfiguration Jul 30, 2024

atomicgamedeveloper and others added 21 commits August 5, 2024 15:11

Update client.yml to run e2e tests

afcafcc

Implement monocart-reporter

5641052

Add codecov git action and passing test

afdd8a5

Fix lint, test and import issues

54b8f25

Merge branch 'feature/distributed-demo' into 320-failing-e2e-tests

0782a63

Update yarn.lock, rm duplicated cmd from client.yml

c0e2b4f

Merge branch '320-failing-e2e-tests' of https://github.com/atomicgame…

c45e491

…developer/DTaaS into 320-failing-e2e-tests

Add playwright installation to git actions workflow

5091475

Install dependencies with playwright in gha

465aac2

Specify config file in yarn cmd

6a60e5a

Refactor and add artifact upload step

843c7b9

Add defaults field with working-directory of client

18640cf

Add defaults field with working-directory of client

bc05caa

Add meaningful default base uri in playwright config, simplify test:e…

a0436db

…2e cmd, rm relative paths

Fix tracing

6bb6084

Change trace path in client.yml

4222b1c

Add debug and use absolute paths in client.yml

4df1766

Run yarn config:test before running e2e tests, rm debug

5625680

Actually remove debug

12e0848

Let dummy test start first, name step in client.yml

0641730

Remove github actions debug tests

5a7dacb

prasadtalasila reviewed Aug 29, 2024

View reviewed changes

Add cmd test:e2e:int, update readme, add console-summary

6957862

codeclimate bot reviewed Sep 5, 2024

View reviewed changes

Move yarn:config:test after yarn install in client.ymæ

c73625d

prasadtalasila reviewed Sep 5, 2024

View reviewed changes

Update readme.md and client.yml

a1777a6

codeclimate bot reviewed Sep 6, 2024

View reviewed changes

client/test/README.md Show resolved Hide resolved

client/test/README.md Show resolved Hide resolved

atomicgamedeveloper added 2 commits September 6, 2024 13:44

Add missing codeblock syntax

afe2841

Rename yarn test:e2e:int to yarn test:e2e:ext

cebb28f

prasadtalasila mentioned this pull request Sep 13, 2024

676 libms commander error on windows #888

Merged

atomicgamedeveloper and others added 5 commits September 17, 2024 18:22

Apply filters to coverage collection and rename test:e2e:int

bb40245

Merge branch 'feature/distributed-demo' into 320-failing-e2e-tests

9e30243

Build the website before trying to copy into it

34b48ee

Fix formatting

be49509

Update test/README.md parts about external hosting

fcb7a26

prasadtalasila assigned atomicgamedeveloper Sep 19, 2024

atomicgamedeveloper added 2 commits September 19, 2024 19:18

Remove bug notice in DEVELOPER.md

26b66b1

Update readme.md

20895a1

codeclimate bot reviewed Sep 20, 2024

View reviewed changes

client/test/README.md Outdated Show resolved Hide resolved

client/test/README.md Outdated Show resolved Hide resolved

atomicgamedeveloper added 3 commits September 20, 2024 13:32

Fix code climate issues about readme.md

2d4cc3b

Add Traeffik note to readme

b207020

Add Traeffik note to readme again

b4abc81

prasadtalasila merged commit 14fbd92 into INTO-CPS-Association:feature/distributed-demo Sep 20, 2024
3 checks passed

This was referenced Sep 20, 2024

Playwright tests fail for react website #320

Closed

Playwright test report cannot be parsed by Code Cov #45

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Playwright e2e reconfiguration #871

Playwright e2e reconfiguration #871

atomicgamedeveloper commented Jul 30, 2024

prasadtalasila commented Aug 27, 2024

prasadtalasila commented Aug 29, 2024

prasadtalasila left a comment

prasadtalasila Aug 29, 2024

codeclimate bot Sep 5, 2024

codeclimate bot Sep 5, 2024

codeclimate bot Sep 5, 2024

codeclimate bot Sep 5, 2024

codeclimate bot Sep 5, 2024

prasadtalasila left a comment

prasadtalasila Sep 5, 2024

prasadtalasila Sep 5, 2024

prasadtalasila commented Sep 6, 2024 •

edited

Loading

prasadtalasila commented Sep 7, 2024

atomicgamedeveloper commented Sep 18, 2024

prasadtalasila commented Sep 19, 2024

codeclimate bot commented Sep 20, 2024

Playwright e2e reconfiguration #871

Playwright e2e reconfiguration #871

Conversation

atomicgamedeveloper commented Jul 30, 2024

prasadtalasila commented Aug 27, 2024

prasadtalasila commented Aug 29, 2024

prasadtalasila left a comment

Choose a reason for hiding this comment

prasadtalasila Aug 29, 2024

Choose a reason for hiding this comment

codeclimate bot Sep 5, 2024

Choose a reason for hiding this comment

codeclimate bot Sep 5, 2024

Choose a reason for hiding this comment

codeclimate bot Sep 5, 2024

Choose a reason for hiding this comment

codeclimate bot Sep 5, 2024

Choose a reason for hiding this comment

codeclimate bot Sep 5, 2024

Choose a reason for hiding this comment

prasadtalasila left a comment

Choose a reason for hiding this comment

prasadtalasila Sep 5, 2024

Choose a reason for hiding this comment

prasadtalasila Sep 5, 2024

Choose a reason for hiding this comment

prasadtalasila commented Sep 6, 2024 • edited Loading

prasadtalasila commented Sep 7, 2024

atomicgamedeveloper commented Sep 18, 2024

prasadtalasila commented Sep 19, 2024

Test setup:

Text Corrections

codeclimate bot commented Sep 20, 2024

prasadtalasila commented Sep 6, 2024 •

edited

Loading