Add http mode to library microservice #480
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
Codecov Report
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## feature/distributed-demo #480 +/- ##
============================================================
+ Coverage 63.38% 72.50% +9.11%
============================================================
Files 31 7 -24
Lines 396 120 -276
Branches 26 5 -21
============================================================
- Hits 251 87 -164
+ Misses 130 28 -102
+ Partials 15 5 -10
... and 36 files with indirect coverage changes
|
There is an issue with getting the httpServer from the httpAdapter instance. I know the reason is that the httpServer is first initialized after the app is created.
Almost done with the issue, all that is needed is to read a different config file.
prasadtalasila
force-pushed
the
pr-345
branch
from
38204ad to
7e3c5eb
Compare
|
Code Climate has analyzed commit 7e3c5eb and detected 1 issue on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
prasadtalasila
merged commit 5e795ef
into
INTO-CPS-Association:feature/distributed-demo
5 checks passed
This was referenced Jan 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds http file service to library microservice using cloudcmd package
Improvements over PR #345:
❌ The HTTP tests are failing on github actions. The problem seems to be that the libms service is not starting either directly or via pm2 package in github actions.