Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/ng tests #2080

Closed
wants to merge 3 commits into from
Closed

Fix/ng tests #2080

wants to merge 3 commits into from

Conversation

chrismclarke
Copy link
Member

@chrismclarke chrismclarke commented Sep 4, 2023

PR Checklist

  • PR title descriptive (can be used in release notes)

TODO

  • Builds on top of Feat/datalist runtime override #2040, should merge after
  • Fix or remove all component test specs to include basic row value if parsing parameter_list in ngOnInit
  • Fix service injection issues, creating new mock services to inject where required
  • Fix other test issues
  • Add ng test to web-build action tests
  • Add support for ng test coverage
  • Consider migrating component tests to cypress or other runner (or keeping component tests but adding back e2e)
  • Start to add more meaningful component spec tests (could be follow-up)

Description

Angular has a component and service testing system which is included during new component and service creation, however only partially used for some of the newer services added to the platform.

This PR aims to fix and remove legacy code to allow the testrunner to function, and include any working tests within existing github actions testing pipelines.

https://angular.io/guide/testing

Git Issues

Closes #

Screenshots/Videos

Significant number of test issues to fix

image

image

@chrismclarke chrismclarke mentioned this pull request Sep 4, 2023
9 tasks
@chrismclarke
Copy link
Member Author

@jfmcquade - #2040 now merged so diffs should be much clearer to see minimal changes required to add _row test data for an example component test in case of interest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants