Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Fix tests and incorporate into CI pipeline #2196

Open
1 of 7 tasks
jfmcquade opened this issue Feb 7, 2024 · 0 comments
Open
1 of 7 tasks

[FEATURE] Fix tests and incorporate into CI pipeline #2196

jfmcquade opened this issue Feb 7, 2024 · 0 comments
Labels
feature Work on app features/modules

Comments

@jfmcquade
Copy link
Collaborator

jfmcquade commented Feb 7, 2024

#2197 includes some fixes to allow the test runner to function for some spec tests. That PR includes the fixes originally included in WIP PR #2080 (now closed).

From #2080:

TODO

  • Fix or remove all component test specs to include basic row value if parsing parameter_list in ngOnInit
  • Fix service injection issues, creating new mock services to inject where required
  • Fix other test issues
  • Add ng test to web-build action tests
  • Add support for ng test coverage
  • Consider migrating component tests to cypress or other runner (or keeping component tests but adding back e2e)
  • Start to add more meaningful component spec tests (could be follow-up)

Description

Angular has a component and service testing system which is included during new component and service creation, however only partially used for some of the newer services added to the platform.

This PR aims to fix and remove legacy code to allow the testrunner to function, and include any working tests within existing github actions testing pipelines.

https://angular.io/guide/testing

Git Issues

Closes #

Screenshots/Videos

Significant number of test issues to fix

image

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Work on app features/modules
Projects
None yet
Development

No branches or pull requests

1 participant