Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
TODO - Current code changes
TODO - Tasks identified in #2035
spawnsync
commands which requires full dev environment (e.g. typescript, installed packages etc.). Further work required to make linked packages consumable (either by building into npm package or updating package.json to export src index.ts and putting consumable methods in related index for use. Similarly calling spawnsync should be replaced with worker threadsxlsxWorkbookProcessor
which appears to be running slower now integratedyarn scripts
) in favour of compiled bin execution (yarn app-scripts
)Note - resources related to worker threads
Description
Start of work refactoring scripts that call external dependencies to avoid use of child spawn methods. This involves refactoring packages that use a cli-based approach (
yarn scripts gdrive download
) to export methods that can be used directly (lib-based)Dev Notes
Should notice speed improvements for workflows as they no longer spawn child processes to execute
TODO
Best solution so far likely to assume user has ts-node installed, possibly rewriting imports to local functions and executing. Could looks at reverting esm -> cjs and/or updating ts-node. May also be useful to move deployment config code to own workspace. Alternative could be to change config format to js and return instead of export Refactor/deployment scripts #2086
Git Issues
Closes #
Screenshots/Videos
If useful, provide screenshot or capture to highlight main changes