Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] - Deployment multiple gdrive folders #2081

Closed
chrismclarke opened this issue Sep 10, 2023 · 0 comments · Fixed by #2088
Closed

[FEATURE] - Deployment multiple gdrive folders #2081

chrismclarke opened this issue Sep 10, 2023 · 0 comments · Fixed by #2088
Assignees
Labels
feature Work on app features/modules

Comments

@chrismclarke
Copy link
Member

chrismclarke commented Sep 10, 2023

What?
Add support for providing multiple multiple google drive template and asset folders to sync data from as part of deployment config

Why?
Make it easier to deploy mulitple apps with some common sheets

How?
Deployment config currently uses the property google_drive.sheets_folder_id and google_drive.assets_folder_id

Either these could be extended to support an array of values, e.g.

google_drive:{
    sheets_folder_ids: ['folder_id_1', 'folder_id_2'] 
}

or could consider more generic config property, such as

data_sources: [
   { 
        provider:'google_drive',
        type:'sheets', 
        config:{id:'folder_id_1'}
    },
    { 
        provider:'google_drive',
        type:'sheets', 
        config:{id:'folder_id_2'}
    }
] 

Other details

  • It would be more useful for users to be able to override individual flows detected in override folder even in cases where folder structures and filenames do not match (as the flow names do match), so will need to hold off merging/overriding flows until they have been extracted from sheets. No such problem for assets

  • As this will require changes to various scripts may need to either wait post Refactor: Script dependencies #2061 or try to avoid too many conflicts

  • Would be good to update overrides documentation to include info (and address use case [FEATURE] Data list overrides #1266)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Work on app features/modules
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant