iam: Phase I: API Key #151
Conversation
- iam_endpoint and apikey required - new CLI options and variables - test updates - docs Fixes: #147
| var missingField = utils.isMissingField(this._options.credentials, Object.keys(Consts.exampleCredentials)); | ||
| if (missingField.length !== 0) { | ||
| throw new Error("g11n-pipeline: missing credentials fields: \"" + missingField.join(' ') + "\" - expected: " + Consts.exampleCredentialsString); | ||
| if(this._options.credentials.apikey) { |
There was a problem hiding this comment.
if apikey is present, assume it is IAM.
| if(this._options.basicAuth) { | ||
| // ignore basicAuth. | ||
| // throw Error('basicAuth is not supported'); // TODO: support this- maybe? | ||
| if (this._options.credentials.apikey) { |
There was a problem hiding this comment.
if apikey is present, use the IAM interceptor
|
|
||
| const authHeader = this.API_KEY + ' ' + this.credentials.apikey; | ||
| if(this.VERBOSE) console.log('hmacHeader = ' + authHeader); | ||
| obj.headers.Authorization = authHeader; |
There was a problem hiding this comment.
this is the actual change.
|
note that actually |
lib/gp-iam.js
Outdated
| if(obj.url.indexOf("/swagger.json") !== -1) return obj; // skip for swagger.json | ||
|
|
||
| const authHeader = this.API_KEY + ' ' + this.credentials.apikey; | ||
| if(this.VERBOSE) console.log('hmacHeader = ' + authHeader); |
There was a problem hiding this comment.
do we want to log actual API_KEY in console?
There was a problem hiding this comment.
only if VERBOSE is on.
There was a problem hiding this comment.
I understand that, but I wasn't sure if it should ever be logged, like we never log it in our server side code. So just wanted to make sure it is intentional. I don't know the best practice for JS.
There was a problem hiding this comment.
I will change it to Authorization: API-KEY **** (using replace to obfuscate the actual apikey)
lib/gp-iam.js
Outdated
| if(obj.url.indexOf("/swagger.json") !== -1) return obj; // skip for swagger.json | ||
|
|
||
| const authHeader = this.API_KEY + ' ' + this.credentials.apikey; | ||
| if(this.VERBOSE) console.log('hmacHeader = ' + authHeader); |
There was a problem hiding this comment.
it's a debug comment, i can change it to authHeader
Fixes #147