IAM Support: phase II: token management #156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- make internal client.swaggerClient a getter instead of a property.
(original property at _swaggerClient).
All internal clients must go through this getter.
- support IAM token. No API change.
- Internal env vars:
- GP_USE_APIKEY=true to not use tokens,
- IAM_TOKEN_EXPIRY_THRESHOLD_PROP_KEY to change the expiry derating from
0.85 to something else.
Fixes: #150
|
LGTM. |
sid41
approved these changes
Apr 22, 2019
| @@ -29,12 +42,59 @@ const GpIAM = function GpIAM(credentials) { | |||
| if(!this.credentials || !this.credentials.apikey || !this.credentials.iam_endpoint) { | |||
There was a problem hiding this comment.
Since you are allowing both api key and token for iam auth, you might want to keep check for iam endpoint conditional.
There was a problem hiding this comment.
@sid41 the API states that the iam_endpoint is required, I wanted to keep the credential requirement consistent. Using the API-KEY header is not intended to be a high runner use case.
|
@sid41 may be an intermittent issue with the test run not related to this issue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
followon to #151
make internal client.swaggerClient a getter instead of a property.
(original property at _swaggerClient).
All internal clients must go through this getter.
support IAM token. No API change.
Internal env vars:
0.85 to something else.
Fixes: #150