Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

y2j 1.1.1 (new formula) #12532

Closed
wants to merge 6 commits into from
Closed

Conversation

trinitronx
Copy link
Contributor

@trinitronx trinitronx commented Apr 17, 2017

  • Added new formula: y2j
  • Uses python virtualenv to provide runtime dependency on PyYAML
  • Uses optional dependency on docker for running on a system with only docker.
  • Rebased on latest master branch
  • New Pull Request with changes from code review in y2j 1.1.1 (new formula) #10927

Closes wildducktheories/y2j#4

  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

@trinitronx trinitronx mentioned this pull request Apr 17, 2017
4 tasks
Added new formula: y2j
Uses python virtualenv to provide runtime dependency on PyYAML
Uses optional dependency on docker for running on a system with only docker.

Closes wildducktheories/y2j#4
@trinitronx trinitronx changed the title Add y2j formula y2j 1.1.1 (new formula) Apr 17, 2017
@bfontaine bfontaine added the new formula PR adds a new formula to Homebrew/homebrew-core label Apr 17, 2017
@trinitronx
Copy link
Contributor Author

Seems that the failing test in all cases is:

Error: 1 problem in 1 formula
y2j:

  • GitHub repository not notable enough (<20 forks, <20 watchers and <50 stars)

Seems like this is a new change since my last PR, as it passed tests last time. Also seems like quite a superficial and arbitrary limit given that this project misses the "<50 stars" criteria by a single star

IMHO: More hoops to jump through for software packages to meet "notability" or other requirements inhibits the freedom of Free Open Source Software, stifles innovation by requiring projects to be popular enough to be packaged & distributed by a main channel such as Homebrew, which in itself is a chicken-egg problem. For example:

  • A developer wants to contribute a new software project xyz for free to the community.
  • In order to be "notable" he needs to get his software easily installable and used by a large number of people
  • He decides to package said software to be distributed via package managers
  • Package manager wants any new software project to be "notable" before they allow it in

This results in the bar being too high for a useful piece of software to become popular or available in the package manager in the first place. Imagine if this was the case at the beginning of Linux and distro development... we would not have the open and diverse ecosystem that we do now.

Would love to hear thoughts / discussion on this new policy!

@trinitronx
Copy link
Contributor Author

For the record, I rebased this work just this morning a couple hours ago and it's already saying that this branch is "out-of-date with the base branch". This PR only makes changes to y2j.rb (a new formula) and therefore should not conflict.

@ilovezfs
Copy link
Contributor

pay no attention to that message

@dunn dunn added the python Python use is a significant feature of the PR or issue label Apr 29, 2017
@stale stale bot added the stale No recent activity label May 16, 2017
@stale
Copy link

stale bot commented May 16, 2017

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot closed this May 23, 2017
@trinitronx
Copy link
Contributor Author

trinitronx commented Jun 2, 2017

geez... closed again 😧

Seems that this project does not want new contributions or that people want to set the bar too high to prevent overload of PRs & issues? The fact that there is a bot to auto-close these, with no response from repo owners or collaborators, as well as the new "notability" requirements are preventing this from even being reviewed, much less getting a path to being merged.

Anything I can do here? What is expected of contributors here?

@ilovezfs ilovezfs reopened this Sep 28, 2017
@stale stale bot removed the stale No recent activity label Sep 28, 2017
@ilovezfs
Copy link
Contributor

@trinitronx we're just a little busy.

@JCount
Copy link
Contributor

JCount commented Sep 28, 2017

@trinitronx First, I apologize that we lost track of this.

However, we cannot accept new formulae that rely on a convoluted installation method involving string replacements because a standard one does not exist upstream. That means that upstream would need to construct a more ordinary method of installation that we could use before it would be worth anyone's time to work on constructing a formula for homebrew/core. Something like a setup.py that supports pip install would be a good example of such a method.

If upstream ends up making the necessary changes to support a more standard installation flow, please feel free to open a new PR.

@JCount JCount closed this Sep 28, 2017
@trinitronx
Copy link
Contributor Author

@JCount : Thanks for the response! I've CC'ed this message upstream to wildducktheories/y2j#4

@Homebrew Homebrew locked and limited conversation to collaborators May 4, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
new formula PR adds a new formula to Homebrew/homebrew-core python Python use is a significant feature of the PR or issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants