Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker-less installation packages #4

Open
mcandre opened this issue Aug 1, 2016 · 9 comments
Open

Docker-less installation packages #4

mcandre opened this issue Aug 1, 2016 · 9 comments

Comments

@mcandre
Copy link

mcandre commented Aug 1, 2016

Could y2j publish a package for Homebrew, without using any containers, so that y2j has a more traditional install process for Mac users?

@jonseymour
Copy link
Contributor

I'll have to read up on brew packaging, but sure.

@chvostek
Copy link

I'll +1 this as described in the issue subject. Stand-alone scripts would allow for easier use in FreeBSD, where docker is theoretically available as an add-on package, but may be unstable.

@jonseymour
Copy link
Contributor

jonseymour commented Jan 17, 2017

FWIW: I think if you grab the script y2j.sh and run it like this:

   y2j.sh installer | bash

should produce an installation that works without docker, provided python and the required dependency (the pip package - pyyaml) has been installed.

Not as a convenient as a OS specific package, for sure, but might work for some.

@cesarjorgemartinez
Copy link

Exist a pip package for this?

trinitronx added a commit to trinitronx/homebrew-core that referenced this issue Mar 11, 2017
Added new formula: y2j
Uses python virtualenv to provide runtime dependency on PyYAML
Uses optional dependency on docker for running on a system with only docker.

Closes wildducktheories/y2j#4
@trinitronx
Copy link
Contributor

trinitronx commented Mar 11, 2017

I have just created a Pull Request in Homebrew/homebrew-core#10927

  • Uses python virtualenv to provide runtime dependency on PyYAML
  • Uses optional dependency on docker for running on a system with only docker.

@jonseymour
Copy link
Contributor

@trinitronx Thanks for doing this.

@trinitronx
Copy link
Contributor

@jonseymour, @mcandre, @chvostek: I've run into a bit of a snag trying to get this merged in Homebrew/homebrew-core#10927

I have created another Pull Request: Homebrew/homebrew-core#12532 to try and get this completed. Yet there are now higher bars being set by the Homebrew project (which I humbly disagreed with). I've done this in my free time because I feel that y2j is notable and useful, and sadly didn't have time to go through all review comments before the first PR was merged. Now there are more frustrating hoops to jump through. Feel free to comment, participate & give support on the upstream issue if you wish to see this merged. Thanks!

@trinitronx
Copy link
Contributor

Looks like homebrew-core has gotten back to us on this. I'm cross-posting the response here from Homebrew/homebrew-core#12532 :

JCount commented:
@trinitronx First, I apologize that we lost track of this.

However, we cannot accept new formulae that rely on a convoluted installation method involving string replacements because a standard one does not exist upstream. That means that upstream would need to construct a more ordinary method of installation that we could use before it would be worth anyone's time to work on constructing a formula for homebrew/core. Something like a setup.py that supports pip install would be a good example of such a method.

If upstream ends up making the necessary changes to support a more standard installation flow, please feel free to open a new PR.

So it looks like they want a standard installation method supported upstream from Homebrew. That would mean creating a standard way to install this here in this repo. So pip or other Homebrew-supported packaging method is probably the way to go if we want to be able to brew install y2j via the official channel.

@almereyda
Copy link

It is also preferable to run the script on the host system, since the image measures 265 MiB and is probably not worth the weight.

For most systems it seems the PyYAML dependency must be met, in so https://github.com/wildducktheories/y2j/blob/master/y2j.sh#L85 doesn't fail. The README could mention this.

Then a simple fix for a dockerless install is to replace all docker run ... invokations with exit 1 and a possible explanation of why a certain check would have failed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants