[fix][broker]fix missing return when internalGetReplicatedSubscriptionStatus #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…18477) Signed-off-by: tison <[email protected]>
…r that has a KeySharedPolicy (apache#18345)
* [Doc][Improve] Add landing pages * Add tutorial pages * Update site2/docs/about.md Co-authored-by: momo-jun <[email protected]> * Update site2/docs/install-deploy-upgrade-landing.md Co-authored-by: momo-jun <[email protected]> * Update site2/docs/install-deploy-upgrade-landing.md Co-authored-by: momo-jun <[email protected]> * Update site2/docs/install-deploy-upgrade-landing.md Co-authored-by: momo-jun <[email protected]> * Update site2/docs/install-deploy-upgrade-landing.md Co-authored-by: momo-jun <[email protected]> * Update site2/docs/tutorials-tenant.md Co-authored-by: momo-jun <[email protected]> * Update developers-landing.md * Create tutorials-produce-consume.md * Update site2/docs/tutorials-tenant.md Co-authored-by: momo-jun <[email protected]> * Update site2/docs/tutorials-tenant.md Co-authored-by: momo-jun <[email protected]> * Update site2/docs/tutorials-tenant.md Co-authored-by: momo-jun <[email protected]> * Delete developer-landing.md * Update site2/docs/tutorials-tenant.md Co-authored-by: momo-jun <[email protected]> * Update install-deploy-upgrade-landing.md * Update site2/docs/tutorials-topic.md Co-authored-by: momo-jun <[email protected]> * Update site2/docs/tutorials-produce-consume.md Co-authored-by: momo-jun <[email protected]> * Update site2/docs/tutorials-produce-consume.md Co-authored-by: momo-jun <[email protected]> * Update site2/docs/tutorials-topic.md Co-authored-by: momo-jun <[email protected]> * Typo * Update site2/docs/tutorials-tenant.md Co-authored-by: momo-jun <[email protected]> * Update site2/docs/tutorials-produce-consume.md Co-authored-by: momo-jun <[email protected]> * Update site2/docs/tutorials-produce-consume.md Co-authored-by: momo-jun <[email protected]> * Update site2/docs/tutorials-produce-consume.md Co-authored-by: momo-jun <[email protected]> * Update site2/docs/tutorials-namespace.md Co-authored-by: momo-jun <[email protected]> * Update site2/docs/install-deploy-upgrade-landing.md Co-authored-by: momo-jun <[email protected]> * Update site2/docs/how-to-landing.md Co-authored-by: momo-jun <[email protected]> * fix link and style issues Co-authored-by: momo-jun <[email protected]> Co-authored-by: momo-jun <[email protected]>
apache#18343) ### Motivation Authentication documentation has too many duplicate configurations and some unnecessary configurations. Signed-off-by: Zixuan Liu <[email protected]> Co-authored-by: momo-jun <[email protected]>
Fixes: apache#17921 <strong>Note</strong>: This patch will change metrics names `s_bufferedwriter_batch_record_count` and `s_bufferedwriter_batch_oldest_record_delay_time_second`. These two names were first used in this PR apache#17701, and PR apache#17701 hasn't cherry-picked any branches yet, so this change will not cause any breaking changes. ### Motivation https://github.com/poorbarcode/pulsar/actions/runs/3156649582/jobs/5136584463 https://github.com/apache/pulsar/actions/runs/3156649597/jobs/5136596447 #### Problem-1 If the `Prometheus-Colloctor` which typed `Counter` is named 'xxx_count', then the output `metrics-api` will be named 'xxx_count_count'. `TxnLogBufferedWriterMetricsStats` hits this error. https://github.com/apache/pulsar/blob/fb7307d8f4998e42b18df3a4599fd7ec34cb04a9/pulsar-transaction/coordinator/src/main/java/org/apache/pulsar/transaction/coordinator/impl/TxnLogBufferedWriterMetricsStats.java#L105-L106 ---- #### Problem-2 `PrometheusMetricsTest` defines the standard metrics name(see code below): ``` ["_sum", "_bucket", "_count", "_total", "_created"] ``` But the standard Prometheus name has three others( see: https://github.com/prometheus/client_java/blob/c28b901225e35e7c1df0eacae8b58fdfbb390162/simpleclient/src/main/java/io/prometheus/client/Collector.java#L152-L186 ): ``` ["_info", "_gsum", "_gcount"] ``` https://github.com/apache/pulsar/blob/fb7307d8f4998e42b18df3a4599fd7ec34cb04a9/pulsar-broker/src/test/java/org/apache/pulsar/broker/stats/PrometheusMetricsTest.java#L834-L861 ---- ### Modifications - Make `PrometheusMetricsTest` run with transaction feature - Make txn metrics name conforms to the rule. see: https://prometheus.io/docs/practices/naming/ - Make `PrometheusMetricsTest` support all suffix of prometheus metrics name ### Documentation - [x] `doc-not-needed` (Please explain why) ### Matching PR in forked repository PR in forked repository: - poorbarcode#19
Signed-off-by: tison <[email protected]>
Signed-off-by: tison <[email protected]>
…tracker (apache#18392) In addition, the `validationError` argument in `newMessageAckCommandAndWrite` is never used. ### Modifications Move the `isAckReceiptEnabled` into `ConsumerImpl` and add two methods `acquireReadLock`/`acquireWriteLock` to acquire the read or write lock if ACK receipt is enabled. Remove the `validationError` argument.
Signed-off-by: Zixuan Liu <[email protected]>
) Signed-off-by: tison <[email protected]>
Signed-off-by: tison <[email protected]>
Signed-off-by: tison <[email protected]> Co-authored-by: momo-jun <[email protected]>
…passed through config map (apache#17375)
…ternalSkipAllMessagesForNonPartitionedTopicAsync (apache#18473)
Signed-off-by: tison <[email protected]>
…sage (apache#18511) ### Motivation Currently, if there are duplicated messages whose chunk id is both 0, then it may result in allocating an unused buffer and may lead to the buffer memory leak. ### Modifications * Only allocate the bytebuffer when there is no duplicated chunk message with chunk id 0. Signed-off-by: Zike Yang <[email protected]>
…broker interceptors (apache#18997)
… reduce memory consumption (apache#19009)
…urrentLedgerSize fields (apache#17868)
…trategicTwoPhaseCompactor and TableView. (apache#18195)
…pache#18774) Signed-off-by: tison <[email protected]>
…pache#18996) Co-authored-by: gavingaozhangmin <[email protected]>
…luent version to 6.2.8 (apache#19010)
…meterized string formatting (apache#18968) Co-authored-by: Ali Ahmed <[email protected]>
Co-authored-by: fengwenzhi <[email protected]>
…partitioned topics (apache#19021)
…active release branches (apache#19024) (apache#19034)
Merged
5 tasks
|
/pulsarbot rerun-failure-checks |
|
The pr had no activity for 30 days, mark with Stale label. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Fix missing
return nullif throw any exception wheninternalGetReplicatedSubscriptionStatusModifications
Add
return nullwhen handing exception ininternalGetReplicatedSubscriptionStatus.Verifying this change
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: #7