-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix][broker]fix missing return when internalGetReplicatedSubscriptionStatus #19054
Conversation
/pulsarbot rerun-failure-checks |
Codecov Report
@@ Coverage Diff @@
## master #19054 +/- ##
============================================
- Coverage 47.20% 46.98% -0.22%
+ Complexity 10645 10594 -51
============================================
Files 709 709
Lines 69421 69422 +1
Branches 7449 7449
============================================
- Hits 32769 32620 -149
- Misses 32984 33120 +136
- Partials 3668 3682 +14
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested changes:
if (exception != null) {
...
} else {
...
}
return null;
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch!
…nStatus (apache#19054) ### Motivation Fix missing `return null` if throw any exception when `internalGetReplicatedSubscriptionStatus` ### Modifications Add `return null` when handing exception in `internalGetReplicatedSubscriptionStatus`.
Motivation
Fix missing
return null
if throw any exception wheninternalGetReplicatedSubscriptionStatus
Modifications
Add
return null
when handing exception ininternalGetReplicatedSubscriptionStatus
.Verifying this change
Documentation
doc
doc-required
doc-not-needed
doc-complete
Matching PR in forked repository
PR in forked repository: HQebupt#7