Deal with libc 0.2.165's removal of array size hacks #1393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If necessary, we could support both by using a trait that is implemented for both |
|
I found a better fix that will work even if libc reverts the change. |
xdm67x
approved these changes
Nov 26, 2024
GuillaumeGomez
approved these changes
Nov 26, 2024
|
Thanks! |
KapJI
added a commit
to KapJI/buck2
that referenced
this pull request
Nov 26, 2024
Summary: `sysinfo` is fixed by GuillaumeGomez/sysinfo#1393 which is released as v0.32.1. But there are breaking changes compare to current sysinfo v0.30.11 we have internally and it needs to be migrated. Differential Revision: D66499693
facebook-github-bot
pushed a commit
to facebook/buck2-shims-meta
that referenced
this pull request
Nov 26, 2024
Summary: X-link: facebook/buck2#814 `libc` 0.2.165 was released recently and it breaks `sysinfo` crate for Mac. `sysinfo` is fixed by GuillaumeGomez/sysinfo#1393 which is released as v0.32.1. But there are breaking changes compare to current sysinfo v0.30.11 we have internally and it needs to be migrated. Reviewed By: ndmitchell, Will-MingLun-Li Differential Revision: D66499693 fbshipit-source-id: 390c76f85ce431f39882345500593ae008664b80
facebook-github-bot
pushed a commit
to facebook/buck2
that referenced
this pull request
Nov 26, 2024
Summary: Pull Request resolved: #814 `libc` 0.2.165 was released recently and it breaks `sysinfo` crate for Mac. `sysinfo` is fixed by GuillaumeGomez/sysinfo#1393 which is released as v0.32.1. But there are breaking changes compare to current sysinfo v0.30.11 we have internally and it needs to be migrated. Reviewed By: ndmitchell, Will-MingLun-Li Differential Revision: D66499693 fbshipit-source-id: 390c76f85ce431f39882345500593ae008664b80
|
Changing the private fields wasn't intentional and seems to have a lot of fallout unfortunately. So we are going to revert, I'm not sure if that affects things here (thanks for working around it so quickly) |
|
@tgross35 We depend on 0.2.165, which was yanked. So it'd be nice if we had a 0.2.166 release. |
|
That should be out very soon rust-lang/libc#4147 |
|
Awesome, thanks! |
|
The release just finished https://github.com/rust-lang/libc/releases/tag/0.2.166 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1392.
Libc changed the representation of
libc::vnode_info_path::vip_path.