Skip to content

Commit

Permalink
github: disallow libc 0.2.165 (#814)
Browse files Browse the repository at this point in the history
Summary:
Pull Request resolved: #814

`libc` 0.2.165 was released recently and it breaks `sysinfo` crate for Mac.

`sysinfo` is fixed by GuillaumeGomez/sysinfo#1393 which is released as v0.32.1.

But there are breaking changes compare to current sysinfo v0.30.11 we have internally and it needs to be migrated.

Reviewed By: ndmitchell, Will-MingLun-Li

Differential Revision: D66499693

fbshipit-source-id: 390c76f85ce431f39882345500593ae008664b80
  • Loading branch information
KapJI authored and facebook-github-bot committed Nov 26, 2024
1 parent 9f4f0c2 commit 2374a1e
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 2 deletions.
3 changes: 2 additions & 1 deletion Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -200,7 +200,8 @@ itertools = "0.13.0"
jemallocator = { version = "0.5.0", features = ["profiling"] }
lalrpop = { version = "0.19.7", artifact = "bin" }
lalrpop-util = "0.19.7"
libc = "0.2.147"
# FIXME: libc v0.2.165 breaks sysinfo crate. This is fixed in sysinfo v0.32.1.
libc = ">=0.2.147,<0.2.165"
linked-hash-map = { version = "0.5", features = ["serde_impl"] }
linkme = { version = "0.3.17", features = ["used_linker"] }
log = "0.4"
Expand Down
3 changes: 2 additions & 1 deletion shim/third-party/rust/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,8 @@ itertools = "0.13.0"
jemallocator = { version = "0.5.0", features = ["profiling"] }
lalrpop = { version = "0.19.7", artifact = "bin", features = ["pico-args"] }
lalrpop-util = "0.19.7"
libc = "0.2.132"
# FIXME: libc v0.2.165 breaks sysinfo crate. This is fixed in sysinfo v0.32.1.
libc = ">=0.2.132,<0.2.165"
linked-hash-map = { version = "0.5", features = ["serde_impl"] }
linkme = { version = "0.3.17", features = ["used_linker"] }
log = "0.4"
Expand Down

0 comments on commit 2374a1e

Please sign in to comment.