Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: implement the handle_batch_open_requests #4075

Merged
merged 8 commits into from
Jun 5, 2024
Merged

feat: implement the handle_batch_open_requests #4075

merged 8 commits into from
Jun 5, 2024

Conversation

WenyXu
Copy link
Member

@WenyXu WenyXu commented May 30, 2024 •
edited
Loading

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

#4026

What's changed and what's your intention?

  1. Add the handle_batch_open_requests method for the RegionEngine trait
  2. Implement the handle_batch_open_requests method for mito. It tries to group opening regions by topic and then open regions with the same topic in a batch.

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR requires documentation updates.

@github-actions github-actions bot added the docs-not-required This change does not impact docs. label May 30, 2024
@WenyXu WenyXu force-pushed the feat/batch-open-regions branch 2 times, most recently from 188f6e6 to 1a6078d Compare May 31, 2024 03:22
@WenyXu WenyXu changed the title feat: implement the handle_batch_open_requests feat: implement the handle_batch_open_requests May 31, 2024
@WenyXu WenyXu mentioned this pull request May 31, 2024
Merged
3 tasks
@WenyXu WenyXu force-pushed the feat/batch-open-regions branch 4 times, most recently from cfcb065 to 2608a00 Compare June 4, 2024 11:52
@WenyXu WenyXu mentioned this pull request Jun 4, 2024
Closed
7 tasks
@WenyXu WenyXu marked this pull request as ready for review June 4, 2024 11:53
@WenyXu WenyXu force-pushed the feat/batch-open-regions branch from 2608a00 to a84ddad Compare June 4, 2024 11:58
@codecov Codecov
Copy link

codecov bot commented Jun 4, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 92.65734% with 21 lines in your changes missing coverage. Please review.

Project coverage is 85.15%. Comparing base (c0aed1d) to head (4d3bdda).
Report is 3 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #4075      +/-   ##
==========================================
- Coverage   85.44%   85.15%   -0.29%     
==========================================
  Files         992      993       +1     
  Lines      173377   173751     +374     
==========================================
- Hits       148141   147964     -177     
- Misses      25236    25787     +551

evenyag
evenyag reviewed Jun 4, 2024
View reviewed changes
src/store-api/src/region_engine.rs Outdated Show resolved Hide resolved
src/mito2/src/worker/handle_open.rs Outdated Show resolved Hide resolved
src/mito2/src/test_util.rs Outdated Show resolved Hide resolved
src/mito2/src/wal/entry_distributor.rs Outdated Show resolved Hide resolved
src/mito2/src/wal/entry_reader.rs Show resolved Hide resolved
src/mito2/src/engine.rs Outdated Show resolved Hide resolved
src/mito2/src/engine.rs Show resolved Hide resolved
src/mito2/src/engine.rs Outdated Show resolved Hide resolved
src/mito2/src/engine/batch_open_test.rs Outdated Show resolved Hide resolved
src/mito2/src/engine/batch_open_test.rs Outdated Show resolved Hide resolved
@WenyXu WenyXu requested a review from fengjiachun June 5, 2024 04:03
evenyag
evenyag approved these changes Jun 5, 2024
View reviewed changes
Copy link
Contributor

@evenyag evenyag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

fengjiachun
fengjiachun approved these changes Jun 5, 2024
View reviewed changes
Copy link
Collaborator

@fengjiachun fengjiachun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fengjiachun fengjiachun added this pull request to the merge queue Jun 5, 2024
Merged via the queue into GreptimeTeam:main with commit c23f8ad Jun 5, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evenyag evenyag evenyag approved these changes

@fengjiachun fengjiachun fengjiachun approved these changes

@v0y4g3r v0y4g3r Awaiting requested review from v0y4g3r v0y4g3r is a code owner

@waynexia waynexia Awaiting requested review from waynexia waynexia is a code owner

Assignees
No one assigned
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@WenyXu @fengjiachun @evenyag