Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: run test_flush_reopen_region and test_region_replay with KafkaLogStore #4083

Merged
merged 5 commits into from
Jun 4, 2024

Conversation

WenyXu
Copy link
Member

@WenyXu WenyXu commented May 31, 2024

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

What's changed and what's your intention?

Run test_flush_reopen_region and test_region_replay with KafkaLogStore

Prelude of #4075

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR requires documentation updates.

@WenyXu WenyXu requested review from v0y4g3r, evenyag, waynexia and a team as code owners May 31, 2024 09:57
@github-actions github-actions bot added the docs-not-required This change does not impact docs. label May 31, 2024
@WenyXu WenyXu force-pushed the test-mito-with-kafka-logstore branch from 527979e to 439321e Compare May 31, 2024 10:02
Copy link

codecov bot commented May 31, 2024

Codecov Report

Attention: Patch coverage is 79.09836% with 51 lines in your changes are missing coverage. Please review.

Project coverage is 85.18%. Comparing base (4e5dd1e) to head (d86733c).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4083      +/-   ##
==========================================
- Coverage   85.47%   85.18%   -0.30%     
==========================================
  Files         991      991              
  Lines      173053   173117      +64     
==========================================
- Hits       147920   147467     -453     
- Misses      25133    25650     +517     

@WenyXu WenyXu requested a review from fengjiachun June 3, 2024 02:37
Copy link
Collaborator

@fengjiachun fengjiachun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

src/mito2/Cargo.toml Outdated Show resolved Hide resolved
src/mito2/src/engine/basic_test.rs Outdated Show resolved Hide resolved
@WenyXu WenyXu force-pushed the test-mito-with-kafka-logstore branch from 89f8c5b to d51457b Compare June 3, 2024 06:41
@WenyXu WenyXu force-pushed the test-mito-with-kafka-logstore branch from d51457b to d86733c Compare June 3, 2024 06:43
@WenyXu WenyXu requested a review from evenyag June 4, 2024 02:14
Copy link
Contributor

@v0y4g3r v0y4g3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@WenyXu WenyXu added this pull request to the merge queue Jun 4, 2024
Merged via the queue into GreptimeTeam:main with commit b3a4362 Jun 4, 2024
28 checks passed
@WenyXu WenyXu deleted the test-mito-with-kafka-logstore branch June 4, 2024 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants