-
Notifications
You must be signed in to change notification settings - Fork 328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: implement WalEntryDistributor
, WalEntryReceiver
#4031
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4031 +/- ##
==========================================
- Coverage 85.34% 85.23% -0.12%
==========================================
Files 987 991 +4
Lines 172109 172933 +824
==========================================
+ Hits 146893 147403 +510
- Misses 25216 25530 +314 |
WenyXu
changed the title
feat: implement the
feat: implement the May 24, 2024
LogStoreEntryReader
LogStoreEntryReader
and WalEntryDistributor
, WalEntryReciver
WenyXu
changed the title
feat: implement the
feat: implement the May 24, 2024
LogStoreEntryReader
and WalEntryDistributor
, WalEntryReciver
LogStoreEntryReader
and WalEntryDistributor
, WalEntryReciver
7 tasks
evenyag
reviewed
May 24, 2024
WenyXu
changed the title
feat: implement the
feat: implement May 30, 2024
LogStoreEntryReader
and WalEntryDistributor
, WalEntryReciver
WalEntryDistributor
, WalEntryReciver
evenyag
approved these changes
May 30, 2024
fengjiachun
reviewed
May 30, 2024
3 tasks
fengjiachun
approved these changes
May 31, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
WenyXu
changed the title
feat: implement
feat: implement Jun 21, 2024
WalEntryDistributor
, WalEntryReciver
WalEntryDistributor
, WalEntryReceiver
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the GreptimeDB CLA.
Refer to a related PR or issue link (optional)
#4026
What's changed and what's your intention?
WalEntryDistributor
, which reads and raw WAL entries from the topic and distributes them toWalEntryReceiver
based on RegionId andstart_id
.WalEntryReceiver,
which receives raw WAL entries from theWalEntryDistributor,
and decodes raw WAL entries into upper-level WAL entries.wait for #4038Checklist