-
Notifications
You must be signed in to change notification settings - Fork 333
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(tql): add initial support for start,stop,step as sql functions #3507
feat(tql): add initial support for start,stop,step as sql functions #3507
Conversation
add |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3507 +/- ##
==========================================
- Coverage 85.41% 85.07% -0.35%
==========================================
Files 931 931
Lines 154531 154806 +275
==========================================
- Hits 131997 131696 -301
- Misses 22534 23110 +576 |
…, evaluation and simplification stages
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking this! I left some style sugg.:
tests/cases/standalone/common/tql-explain-analyze/explain.result
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this!
Thank you @waynexia for useful tips(especially with the simplification) and help during the implementation! |
Thanks for keeping working on this huge and exciting feature. I can't wait to try it out! |
I hereby agree to the terms of the GreptimeDB CLA.
Refer to a related PR or issue link (optional)
#3452
#3453 (
lookback
parameter)What's changed and what's your intention?
TQL parser accepts SQL functions such as
now()
forstart
,end
andstep
parameters:Please explain IN DETAIL what the changes are in this PR and why they are needed:
tql_parser
logic with small pre-planning and pre-executing phases to evaluatestart
,end
andstep
into number (timestamp) if those parameter were passed as SQL functions; The logic is the followingChecklist