-
Notifications
You must be signed in to change notification settings - Fork 333
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Parameterize lookback
in PromQL
#3453
Comments
With this feature, we can have the ability to use PromQL to query exact data with no false result via setting |
@etolbakov Cool! Feel free to link this issue in your PR like |
@waynexia BTW I wonder what is the difference between the code path of PromQL and TQL. Seems it's quite a bit undocumented. |
This is not part of #3492.
They are the same after parser phase |
Is this closed by #3630? |
yeah, let's close it @tisonkun |
What problem does the new feature solve?
Prometheus now supports to set
lookback
per query prometheus/prometheus#9946In our framework, this parameter is defaulted to
5m
and can't be overridden per query at presentgreptimedb/src/query/src/parser.rs
Lines 39 to 40 in a218f12
But the underlying planner does have a parameter
greptimedb/src/promql/src/planner.rs
Lines 83 to 88 in a218f12
What does the feature do?
Support setting
lookback
per query as well.Prometheus hasn't exposed this to HTTP API, so we only need to change the TQL part for now.
Specifically, makes TQL accept the new fourth optional parameter for lookback and handle it in the planner:
Implementation challenges
No response
The text was updated successfully, but these errors were encountered: