Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: commit_short sqlness test case #3313

Merged
merged 5 commits into from
Feb 18, 2024
Merged

Conversation

tisonkun
Copy link
Collaborator

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

WIP - see why sqlness tests fail.

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR does not require documentation updates.

Refer to a related PR or issue link (optional)

@github-actions github-actions bot added docs-not-required This change does not impact docs. Size: S and removed docs-not-required This change does not impact docs. labels Feb 18, 2024
@tisonkun tisonkun added the docs-not-required This change does not impact docs. label Feb 18, 2024
@tisonkun tisonkun changed the title ci: debug sqlness jobs fix: commit_short sqlness test case Feb 18, 2024
@tisonkun tisonkun requested review from WenyXu and waynexia and removed request for WenyXu February 18, 2024 11:19
Copy link

codecov bot commented Feb 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4e04a4e) 85.53% compared to head (eac9a1d) 85.11%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3313      +/-   ##
==========================================
- Coverage   85.53%   85.11%   -0.42%     
==========================================
  Files         872      872              
  Lines      141967   141967              
==========================================
- Hits       121432   120842     -590     
- Misses      20535    21125     +590     

@tisonkun tisonkun enabled auto-merge February 18, 2024 11:28
@tisonkun
Copy link
Collaborator Author

Since we require sqlness now, this PR blocks other PRs. Maybe you can give a review on this PR first @waynexia @WenyXu

Signed-off-by: tison <[email protected]>
@tisonkun tisonkun added this pull request to the merge queue Feb 18, 2024
Merged via the queue into GreptimeTeam:main with commit 2a26c01 Feb 18, 2024
16 checks passed
@tisonkun tisonkun deleted the debug-sqlness branch February 18, 2024 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants