fix: commit_short sqlness test case (#3313)

* ci: debug sqlness jobs Signed-off-by: tison <[email protected]> * fix: commit_short test case Signed-off-by: tison <[email protected]> * fixup! fix: commit_short test case Signed-off-by: tison <[email protected]> * fixup! fixup! fix: commit_short test case Signed-off-by: tison <[email protected]> * revert uploading Signed-off-by: tison <[email protected]> --------- Signed-off-by: tison <[email protected]>
GreptimeTeam · Feb 18, 2024 · 2a26c01 · 2a26c01
1 parent 4e04a4e
commit 2a26c01
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 5 deletions.
diff --git a/.github/workflows/develop.yml b/.github/workflows/develop.yml
@@ -139,7 +139,8 @@ jobs:
       - name: Unzip binaries
         run: tar -xvf ./bins.tar.gz
       - name: Run sqlness
-        run: ./bins/sqlness-runner -c ./tests/cases --bins-dir ./bins
+        run: RUST_BACKTRACE=1 ./bins/sqlness-runner -c ./tests/cases --bins-dir ./bins
+      # FIXME: Logs cannot found be on failure (or even success). Need to figure out the cause.
       - name: Upload sqlness logs
         if: always()
         uses: actions/upload-artifact@v3
@@ -170,7 +171,8 @@ jobs:
         working-directory: tests-integration/fixtures/kafka
         run: docker compose -f docker-compose-standalone.yml up -d --wait
       - name: Run sqlness
-        run: ./bins/sqlness-runner -w kafka -k 127.0.0.1:9092 -c ./tests/cases --bins-dir ./bins
+        run: RUST_BACKTRACE=1 ./bins/sqlness-runner -w kafka -k 127.0.0.1:9092 -c ./tests/cases --bins-dir ./bins
+      # FIXME: Logs cannot be found on failure (or even success). Need to figure out the cause.
       - name: Upload sqlness logs
         if: always()
         uses: actions/upload-artifact@v3

diff --git a/tests/cases/standalone/common/function/system.result b/tests/cases/standalone/common/function/system.result
@@ -1,12 +1,12 @@
 -- SQLNESS REPLACE branch:\s+.+ branch: BRANCH
 -- SQLNESS REPLACE commit:\s+.+ commit: COMMIT
--- SQLNESS REPLACE commit+\s+short:\s+.+ commit short: COMMIT SHORT
+-- SQLNESS REPLACE commit_short:\s+.+ commit_short: COMMIT_SHORT
 -- SQLNESS REPLACE dirty:\s+.+ dirty: DIRTY
 -- SQLNESS REPLACE version:\s+.+ version: VERSION
 -- SQLNESS REPLACE [\s\-]+
 SELECT build();
 
-++|build()|++|branch:BRANCH|commit:COMMIT|commitshort:COMMITSHORT|dirty:DIRTY|version:VERSION++
+++|build()|++|branch:BRANCH|commit:COMMIT|commit_short:COMMIT_SHORT|dirty:DIRTY|version:VERSION++
 
 -- SQLNESS REPLACE greptimedb-[\d\.]+ greptimedb-VERSION
 SELECT version();

diff --git a/tests/cases/standalone/common/function/system.sql b/tests/cases/standalone/common/function/system.sql
@@ -1,6 +1,6 @@
 -- SQLNESS REPLACE branch:\s+.+ branch: BRANCH
 -- SQLNESS REPLACE commit:\s+.+ commit: COMMIT
--- SQLNESS REPLACE commit+\s+short:\s+.+ commit short: COMMIT SHORT
+-- SQLNESS REPLACE commit_short:\s+.+ commit_short: COMMIT_SHORT
 -- SQLNESS REPLACE dirty:\s+.+ dirty: DIRTY
 -- SQLNESS REPLACE version:\s+.+ version: VERSION
 -- SQLNESS REPLACE [\s\-]+