fix(wal): replay memtable should from flushed_entry_id + 1
#3038
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
docs-not-required
WenyXu
force-pushed
the
fix/replay-memtable
branch
from
6a76c16 to
a8cb592
Compare
niebayes
approved these changes
Dec 28, 2023
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3038 +/- ##
==========================================
- Coverage 85.50% 85.02% -0.48%
==========================================
Files 793 793
Lines 128447 128451 +4
==========================================
- Hits 109825 109221 -604
- Misses 18622 19230 +608 |
evenyag
reviewed
Dec 28, 2023
niebayes
changed the title
flushed_entry_id + 1flushed_entry_id + 1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the GreptimeDB CLA
What's changed and what's your intention?
Fixed replay memtable incorrectly. It should replay from
flushed_entry_id + 1.Checklist
Refer to a related PR or issue link (optional)