Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a test to ensure the RegionOpener replays the memtable properly. #3041

Open
WenyXu opened this issue Dec 29, 2023 · 0 comments
Open

Add a test to ensure the RegionOpener replays the memtable properly. #3041

WenyXu opened this issue Dec 29, 2023 · 0 comments
Labels
A-storage Involves code in storage engines

Comments

@WenyXu
Copy link
Member

WenyXu commented Dec 29, 2023

What type of enhancement is this?

Tech debt reduction

What does the enhancement do?

Previously, #3038, we fixed this issue. After region flush, the obsolete log entries will be removed; therefore, it always works as "expected" if we try to replay the last_flushed_id on a raft-engine-based region(i.e., although the caller trying to replay from the last_flushed_id, the underlying returns the entries from last_flushed_id + 1 actually. However, the Kafka log store never removed the obsolete log entries, and this bug was found.

Implementation challenges

No response

@WenyXu WenyXu added the A-storage Involves code in storage engines label Dec 29, 2023
@niebayes niebayes self-assigned this Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-storage Involves code in storage engines
Projects
None yet
Development

No branches or pull requests

2 participants