Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: hide RegionRoute behind TableRouteValue #2989

Merged
merged 7 commits into from
Dec 25, 2023
Merged

refactor: hide RegionRoute behind TableRouteValue #2989

merged 7 commits into from
Dec 25, 2023

Conversation

MichaelScofield
Copy link
Collaborator

@MichaelScofield MichaelScofield commented Dec 25, 2023 •
edited
Loading

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

Metric Engine table route, part 2

Next PR will create metric engine table, with its table route.

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.

Refer to a related PR or issue link (optional)

#2864

@MichaelScofield MichaelScofield added the docs-not-required This change does not impact docs. label Dec 25, 2023
@codecov Codecov
Copy link

codecov bot commented Dec 25, 2023 •
edited
Loading

Codecov Report

Attention: 57 lines in your changes are missing coverage. Please review.

Comparison is base (06fd7fd) 85.87% compared to head (71b2c91) 85.15%.
Report is 6 commits behind head on develop.

Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #2989      +/-   ##
===========================================
- Coverage    85.87%   85.15%   -0.72%     
===========================================
  Files          780      783       +3     
  Lines       126184   126612     +428     
===========================================
- Hits        108356   107818     -538     
- Misses       17828    18794     +966

WenyXu
WenyXu reviewed Dec 25, 2023
View reviewed changes
src/cmd/src/cli/bench/metadata.rs Outdated Show resolved Hide resolved
src/common/meta/src/ddl/create_table.rs Outdated Show resolved Hide resolved
src/common/meta/src/key.rs Show resolved Hide resolved
src/meta-srv/src/procedure/region_migration/test_util.rs Outdated Show resolved Hide resolved
@MichaelScofield MichaelScofield marked this pull request as draft December 25, 2023 06:09
@MichaelScofield MichaelScofield marked this pull request as ready for review December 25, 2023 06:15
@MichaelScofield
Copy link
Collaborator Author

@WenyXu PTAL

@WenyXu
Copy link
Member

WenyXu commented Dec 25, 2023

@WenyXu PTAL

Rustfmt failed.

@MichaelScofield
Copy link
Collaborator Author

@WenyXu fixed

WenyXu
WenyXu approved these changes Dec 25, 2023
View reviewed changes
Copy link
Member

@WenyXu WenyXu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

fengjiachun
fengjiachun approved these changes Dec 25, 2023
View reviewed changes
Copy link
Collaborator

@fengjiachun fengjiachun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MichaelScofield MichaelScofield added this pull request to the merge queue Dec 25, 2023
Merged via the queue into GreptimeTeam:develop with commit 1641fd5 Dec 25, 2023
13 checks passed
@MichaelScofield MichaelScofield deleted the refactor/hide-region-route branch December 25, 2023 11:53
@waynexia waynexia mentioned this pull request Dec 26, 2023
Closed
8 tasks
waynexia added a commit to waynexia/greptimedb that referenced this pull request Dec 26, 2023
@waynexia
Revert "refactor: hide RegionRoute behind TableRouteValue (Grepti…
d3a8032 
…meTeam#2989)"

This reverts commit 1641fd5.
@waynexia waynexia mentioned this pull request Dec 26, 2023
Merged
3 tasks
github-merge-queue bot pushed a commit that referenced this pull request Dec 26, 2023
@waynexia
fix: revert unfinished route table change (#3008)
8ce8a8f 
* Revert "refactor: hide `RegionRoute` behind `TableRouteValue` (#2989)"

This reverts commit 1641fd5.

* Revert "feat: MetricsEngine table route (part 1) (#2952)"

This reverts commit 6ac47e9.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WenyXu WenyXu WenyXu approved these changes

@fengjiachun fengjiachun fengjiachun approved these changes

@waynexia waynexia Awaiting requested review from waynexia

Assignees
No one assigned
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MichaelScofield @WenyXu @fengjiachun