fix: revert unfinished route table change #3008
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…meTeam#2989)" This reverts commit 1641fd5.
This reverts commit 6ac47e9.
MichaelScofield
approved these changes
Dec 26, 2023
WenyXu
approved these changes
Dec 26, 2023
fengjiachun
approved these changes
Dec 26, 2023
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #3008 +/- ##
===========================================
- Coverage 85.74% 85.19% -0.55%
===========================================
Files 784 784
Lines 126802 126766 -36
===========================================
- Hits 108721 107997 -724
- Misses 18081 18769 +688 |
Merged
via the queue into
GreptimeTeam:develop
with commit Dec 26, 2023
8ce8a8f
18 of 22 checks passed
MichaelScofield
added a commit
that referenced
this pull request
Dec 26, 2023
This reverts commit 8ce8a8f.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the GreptimeDB CLA
What's changed and what's your intention?
This PR reverts #2989, which breaks the existing functionalities of metric engein. And to avoid introduce breaking change, this PR also reverts #2952.
Those two PR can be cherry-picked back to main branch after releasing
v0.5Checklist
Refer to a related PR or issue link (optional)