Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: MetricsEngine table route (part 1) #2952

Merged
merged 3 commits into from
Dec 20, 2023
Merged

feat!: MetricsEngine table route (part 1) #2952

merged 3 commits into from
Dec 20, 2023

Conversation

MichaelScofield
Copy link
Collaborator

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

make TableRouteValue an enum to add the variant of MetricsEngine table route

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.

Refer to a related PR or issue link (optional)

@codecov Codecov
Copy link

codecov bot commented Dec 18, 2023 •
edited
Loading

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (97c3755) 85.81% compared to head (3728219) 85.32%.
Report is 2 commits behind head on develop.

Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #2952      +/-   ##
===========================================
- Coverage    85.81%   85.32%   -0.50%     
===========================================
  Files          767      767              
  Lines       123745   123721      -24     
===========================================
- Hits        106191   105563     -628     
- Misses       17554    18158     +604

WenyXu
WenyXu reviewed Dec 19, 2023
View reviewed changes
src/common/meta/src/key/table_route.rs Outdated Show resolved Hide resolved
src/common/meta/src/key/table_route.rs Outdated Show resolved Hide resolved
src/common/meta/src/key/table_route.rs Outdated Show resolved Hide resolved
@MichaelScofield MichaelScofield marked this pull request as draft December 19, 2023 03:31
@MichaelScofield MichaelScofield marked this pull request as ready for review December 19, 2023 03:39
@MichaelScofield MichaelScofield force-pushed the refactor/table-route-enum branch from d1e43fc to ab862c8 Compare December 20, 2023 06:59
@MichaelScofield
Copy link
Collaborator Author

MichaelScofield commented Dec 20, 2023 •
edited
Loading

@fengjiachun @waynexia @WenyXu PTAL

WenyXu
WenyXu approved these changes Dec 20, 2023
View reviewed changes
Copy link
Member

@WenyXu WenyXu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

src/common/meta/src/key/table_route.rs Outdated Show resolved Hide resolved
fengjiachun
fengjiachun approved these changes Dec 20, 2023
View reviewed changes
Copy link
Collaborator

@fengjiachun fengjiachun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MichaelScofield MichaelScofield added this pull request to the merge queue Dec 20, 2023
Merged via the queue into GreptimeTeam:develop with commit 6ac47e9 Dec 20, 2023
13 checks passed
@MichaelScofield MichaelScofield deleted the refactor/table-route-enum branch December 20, 2023 07:43
shuiyisong added a commit to shuiyisong/greptimedb that referenced this pull request Dec 21, 2023
@shuiyisong
Revert "feat: MetricsEngine table route (part 1) (GreptimeTeam#2952)"
e68fa32 
This reverts commit 6ac47e9.
shuiyisong added a commit to shuiyisong/greptimedb that referenced this pull request Dec 24, 2023
@shuiyisong
Revert "feat: MetricsEngine table route (part 1) (GreptimeTeam#2952)"
48c4bc3 
This reverts commit 6ac47e9.
@WenyXu WenyXu added the breaking-change This pull request contains breaking changes. label Dec 25, 2023
@github-actions github-actions bot removed the breaking-change This pull request contains breaking changes. label Dec 25, 2023
@WenyXu WenyXu changed the title feat: MetricsEngine table route (part 1) feat!: MetricsEngine table route (part 1) Dec 25, 2023
@github-actions github-actions bot added the breaking-change This pull request contains breaking changes. label Dec 25, 2023
waynexia added a commit to waynexia/greptimedb that referenced this pull request Dec 26, 2023
@waynexia
Revert "feat: MetricsEngine table route (part 1) (GreptimeTeam#2952)"
a7e0695 
This reverts commit 6ac47e9.
@waynexia waynexia mentioned this pull request Dec 26, 2023
Merged
3 tasks
github-merge-queue bot pushed a commit that referenced this pull request Dec 26, 2023
@waynexia
fix: revert unfinished route table change (#3008)
8ce8a8f 
* Revert "refactor: hide `RegionRoute` behind `TableRouteValue` (#2989)"

This reverts commit 1641fd5.

* Revert "feat: MetricsEngine table route (part 1) (#2952)"

This reverts commit 6ac47e9.
shuiyisong added a commit to shuiyisong/greptimedb that referenced this pull request Jan 3, 2024
@shuiyisong
Reapply "feat: MetricsEngine table route (part 1) (GreptimeTeam#2952)"
edc835c 
This reverts commit 48c4bc3.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WenyXu WenyXu WenyXu approved these changes

@fengjiachun fengjiachun fengjiachun approved these changes

@waynexia waynexia Awaiting requested review from waynexia

Assignees

@MichaelScofield MichaelScofield

Labels
breaking-change This pull request contains breaking changes.
Projects
Metric Engine
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@MichaelScofield @fengjiachun @waynexia @WenyXu