Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: windows build and check ci check for windows #2819

Merged
merged 1 commit into from
Nov 27, 2023

Conversation

sunng87
Copy link
Member

@sunng87 sunng87 commented Nov 27, 2023

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

Resolves build issue introduced in #2791 and attempt to add cargo check for windows platform.

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.

Refer to a related PR or issue link (optional)

Copy link

codecov bot commented Nov 27, 2023

Codecov Report

Merging #2819 (2905f17) into develop (9e58bba) will decrease coverage by 0.06%.
The diff coverage is n/a.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2819      +/-   ##
===========================================
- Coverage    84.74%   84.69%   -0.06%     
===========================================
  Files          732      732              
  Lines       114657   114657              
===========================================
- Hits         97168    97109      -59     
- Misses       17489    17548      +59     

@evenyag evenyag enabled auto-merge November 27, 2023 03:41
@evenyag evenyag added this pull request to the merge queue Nov 27, 2023
Merged via the queue into develop with commit bd9c2f2 Nov 27, 2023
13 checks passed
@evenyag evenyag deleted the fix/windows-build-jemalloc branch November 27, 2023 03:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants