Skip to content

Commit

Permalink
fix: windows build and check ci check for windows (#2819)
Browse files Browse the repository at this point in the history
  • Loading branch information
sunng87 authored Nov 27, 2023
1 parent b3edbef commit bd9c2f2
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 3 deletions.
5 changes: 4 additions & 1 deletion .github/workflows/develop.yml
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,10 @@ jobs:
check:
name: Check
if: github.event.pull_request.draft == false
runs-on: ubuntu-20.04
runs-on: ${{ matrix.os }}
strategy:
matrix:
os: [ windows-latest-8-cores, ubuntu-20.04 ]
timeout-minutes: 60
steps:
- uses: actions/checkout@v3
Expand Down
7 changes: 5 additions & 2 deletions src/servers/src/error.rs
Original file line number Diff line number Diff line change
Expand Up @@ -339,6 +339,7 @@ pub enum Error {
source: crate::http::pprof::nix::Error,
},

#[cfg(not(windows))]
#[snafu(display("Failed to update jemalloc metrics"))]
UpdateJemallocMetrics {
#[snafu(source)]
Expand Down Expand Up @@ -412,8 +413,10 @@ impl ErrorExt for Error {
| TcpIncoming { .. }
| CatalogError { .. }
| GrpcReflectionService { .. }
| BuildHttpResponse { .. }
| UpdateJemallocMetrics { .. } => StatusCode::Internal,
| BuildHttpResponse { .. } => StatusCode::Internal,

#[cfg(not(windows))]
UpdateJemallocMetrics { .. } => StatusCode::Internal,

CollectRecordbatch { .. } => StatusCode::EngineExecuteQuery,

Expand Down

0 comments on commit bd9c2f2

Please sign in to comment.