-
Notifications
You must be signed in to change notification settings - Fork 328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add migration start step #2756
Merged
fengjiachun
merged 3 commits into
GreptimeTeam:develop
from
WenyXu:feat/migration-start
Nov 17, 2023
Merged
feat: add migration start step #2756
fengjiachun
merged 3 commits into
GreptimeTeam:develop
from
WenyXu:feat/migration-start
Nov 17, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
39 tasks
WenyXu
force-pushed
the
feat/migration-start
branch
3 times, most recently
from
November 16, 2023 05:06
cac8a98
to
81596f0
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #2756 +/- ##
===========================================
- Coverage 85.46% 85.02% -0.44%
===========================================
Files 772 777 +5
Lines 125283 126039 +756
===========================================
+ Hits 107069 107161 +92
- Misses 18214 18878 +664 |
WenyXu
force-pushed
the
feat/migration-start
branch
from
November 16, 2023 06:36
81596f0
to
bd1a545
Compare
WenyXu
changed the title
feat: add migration start state
feat: add migration start step
Nov 16, 2023
2 tasks
fengjiachun
reviewed
Nov 16, 2023
src/meta-srv/src/procedure/region_migration/downgrade_leader_region.rs
Outdated
Show resolved
Hide resolved
WenyXu
force-pushed
the
feat/migration-start
branch
from
November 16, 2023 19:29
e7f536b
to
a2cba0f
Compare
MichaelScofield
approved these changes
Nov 17, 2023
@fengjiachun PTAL |
fengjiachun
approved these changes
Nov 17, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the GreptimeDB CLA
What's changed and what's your intention?
Add migration start step
to_peer
, go to theMigrationEnd
state.to_peer
, go to theDowngradeLeader
state.OpenCandidateRegion
state.Behaviors:
Abort(non-retry):
Retry:
Checklist
Refer to a related PR or issue link (optional)
#2700