Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add migration start step #2756

Merged
merged 3 commits into from
Nov 17, 2023

Conversation

WenyXu
Copy link
Member

@WenyXu WenyXu commented Nov 16, 2023

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

Add migration start step

  • If the expected leader region has been opened on to_peer, go to the MigrationEnd state.
  • If the candidate region has been opened on to_peer, go to the DowngradeLeader state.
  • Else go to the OpenCandidateRegion state.

Behaviors:

Abort(non-retry):

  • TableRoute is not found.
  • RegionRoute is not found.
  • Leader peer of RegionRoute is not found.

Retry:

  • Failed to retrieve the metadata of table.

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.

Refer to a related PR or issue link (optional)

#2700

@WenyXu WenyXu mentioned this pull request Nov 16, 2023
39 tasks
@WenyXu WenyXu force-pushed the feat/migration-start branch 3 times, most recently from cac8a98 to 81596f0 Compare November 16, 2023 05:06
Copy link

codecov bot commented Nov 16, 2023

Codecov Report

Merging #2756 (a2cba0f) into develop (9bd1013) will decrease coverage by 0.44%.
Report is 2 commits behind head on develop.
The diff coverage is 89.67%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2756      +/-   ##
===========================================
- Coverage    85.46%   85.02%   -0.44%     
===========================================
  Files          772      777       +5     
  Lines       125283   126039     +756     
===========================================
+ Hits        107069   107161      +92     
- Misses       18214    18878     +664     

@WenyXu WenyXu marked this pull request as draft November 16, 2023 06:30
@WenyXu WenyXu force-pushed the feat/migration-start branch from 81596f0 to bd1a545 Compare November 16, 2023 06:36
@WenyXu WenyXu marked this pull request as ready for review November 16, 2023 06:36
@WenyXu WenyXu changed the title feat: add migration start state feat: add migration start step Nov 16, 2023
@WenyXu WenyXu mentioned this pull request Nov 16, 2023
2 tasks
@WenyXu
Copy link
Member Author

WenyXu commented Nov 16, 2023

@MichaelScofield @fengjiachun PTAL

@WenyXu WenyXu force-pushed the feat/migration-start branch from e7f536b to a2cba0f Compare November 16, 2023 19:29
@WenyXu
Copy link
Member Author

WenyXu commented Nov 17, 2023

@fengjiachun PTAL

Copy link
Collaborator

@fengjiachun fengjiachun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fengjiachun fengjiachun added this pull request to the merge queue Nov 17, 2023
Merged via the queue into GreptimeTeam:develop with commit 3ab4947 Nov 17, 2023
12 checks passed
@WenyXu WenyXu self-assigned this Nov 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

3 participants