Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add open candidate region step #2757

Merged

Conversation

WenyXu
Copy link
Member

@WenyXu WenyXu commented Nov 16, 2023

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

This step opens the candidate region on to_peer.

Behaviors:

Abort(non-retry):

  • Table Info is not found.
  • The Datanode is unreachable(e.g., Candidate pusher is not found).
  • Unexpected instruction reply.
  • Another procedure is opening the candidate region.

Retry:

  • Exceeded deadline of open instruction.
  • Datanode failed to open the candidate region.

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.

Refer to a related PR or issue link (optional)

#2700
Waits for #2756

Copy link

codecov bot commented Nov 16, 2023

Codecov Report

Merging #2757 (028339a) into develop (3ab4947) will decrease coverage by 0.30%.
Report is 1 commits behind head on develop.
The diff coverage is 96.11%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2757      +/-   ##
===========================================
- Coverage    85.36%   85.07%   -0.30%     
===========================================
  Files          777      777              
  Lines       126187   126906     +719     
===========================================
+ Hits        107718   107960     +242     
- Misses       18469    18946     +477     

@WenyXu WenyXu marked this pull request as draft November 17, 2023 03:38
@WenyXu WenyXu force-pushed the feat/open-candidate-region branch from 9620c77 to 861369d Compare November 17, 2023 03:42
@WenyXu WenyXu marked this pull request as ready for review November 17, 2023 06:49
@WenyXu WenyXu force-pushed the feat/open-candidate-region branch from 861369d to 1c613a7 Compare November 17, 2023 07:48
src/meta-srv/src/error.rs Outdated Show resolved Hide resolved
@WenyXu WenyXu self-assigned this Nov 18, 2023
@MichaelScofield MichaelScofield added this pull request to the merge queue Nov 20, 2023
Merged via the queue into GreptimeTeam:develop with commit 4fcda27 Nov 20, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

3 participants