Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: impl Vector, DataType traits for decimal128 #2727

Merged
merged 9 commits into from
Nov 16, 2023
Merged

feat: impl Vector, DataType traits for decimal128 #2727

merged 9 commits into from
Nov 16, 2023

Conversation

QuenKar
Copy link
Contributor

@QuenKar QuenKar commented Nov 10, 2023 •
edited
Loading

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

main change:

  • impl Decimal128Type, Decimal128Vector and Decimal128Builder in datatypes crate.
  • impl relevant traits for them.
  • use Vector cast function for Value cast to keep behavior consistant.

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.

Refer to a related PR or issue link (optional)

#2682

@QuenKar QuenKar marked this pull request as ready for review November 10, 2023 08:40
@codecov Codecov
Copy link

codecov bot commented Nov 10, 2023 •
edited
Loading

Codecov Report

Merging #2727 (a8f01cf) into develop (8fd0766) will decrease coverage by 0.24%.
Report is 19 commits behind head on develop.
The diff coverage is 63.60%.

Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #2727      +/-   ##
===========================================
- Coverage    85.23%   84.99%   -0.24%     
===========================================
  Files          765      774       +9     
  Lines       124013   125796    +1783     
===========================================
+ Hits        105697   106915    +1218     
- Misses       18316    18881     +565

@QuenKar QuenKar force-pushed the feat/decimal128-traits-without-sqlness branch from 915656f to ce3d576 Compare November 12, 2023 05:30
killme2008
killme2008 reviewed Nov 13, 2023
View reviewed changes
src/common/grpc/src/select.rs Show resolved Hide resolved
src/datatypes/src/types/cast.rs Show resolved Hide resolved
src/datatypes/src/types/decimal_type.rs Show resolved Hide resolved
src/datatypes/src/value.rs Outdated Show resolved Hide resolved
src/datatypes/src/value.rs Outdated Show resolved Hide resolved
src/datatypes/src/vectors/decimal.rs Outdated Show resolved Hide resolved
src/datatypes/src/vectors/decimal.rs Outdated Show resolved Hide resolved
src/sql/src/statements.rs Show resolved Hide resolved
src/datatypes/src/vectors/decimal.rs Outdated Show resolved Hide resolved
evenyag
evenyag reviewed Nov 14, 2023
View reviewed changes
src/datatypes/src/data_type.rs Outdated Show resolved Hide resolved
src/datatypes/src/scalars.rs Outdated Show resolved Hide resolved
src/datatypes/src/value.rs Outdated Show resolved Hide resolved
src/datatypes/src/vectors/decimal.rs Outdated Show resolved Hide resolved
src/datatypes/src/vectors/decimal.rs Outdated Show resolved Hide resolved
src/datatypes/src/vectors/decimal.rs Outdated Show resolved Hide resolved
src/datatypes/src/vectors/decimal.rs Outdated Show resolved Hide resolved
src/datatypes/src/vectors/decimal.rs Outdated Show resolved Hide resolved
src/datatypes/src/vectors/helper.rs Show resolved Hide resolved
src/sql/src/statements.rs Outdated Show resolved Hide resolved
@QuenKar @killme2008 @evenyag
chore: cr comment
474bd5b 
Co-authored-by: Dennis Zhuang <[email protected]>
Co-authored-by: Yingwen <[email protected]>
@QuenKar QuenKar force-pushed the feat/decimal128-traits-without-sqlness branch from ae832f3 to 474bd5b Compare November 15, 2023 09:03
This was referenced Nov 15, 2023
Closed
Closed
killme2008
killme2008 approved these changes Nov 15, 2023
View reviewed changes
Copy link
Contributor

@killme2008 killme2008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Keep pushing!

@QuenKar QuenKar marked this pull request as draft November 16, 2023 02:13
@QuenKar QuenKar marked this pull request as ready for review November 16, 2023 02:19
evenyag
evenyag approved these changes Nov 16, 2023
View reviewed changes
Copy link
Contributor

@evenyag evenyag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@evenyag evenyag added this pull request to the merge queue Nov 16, 2023
Merged via the queue into GreptimeTeam:develop with commit ae27fbc Nov 16, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evenyag evenyag evenyag approved these changes

@killme2008 killme2008 killme2008 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@QuenKar @killme2008 @evenyag