Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a test for MutableVector datatype method #2754

Closed
QuenKar opened this issue Nov 15, 2023 · 0 comments · Fixed by #2768
Closed

Add a test for MutableVector datatype method #2754

QuenKar opened this issue Nov 15, 2023 · 0 comments · Fixed by #2768
Assignees
@QuenKar
Labels
C-enhancement Category Enhancements

Comments

@QuenKar
Copy link
Contributor

QuenKar commented Nov 15, 2023 •
edited
Loading

What type of enhancement is this?

Tech debt reduction

What does the enhancement do?

add a test for all VectorBuilders for the data_type method which implements in MutableVector trait.

Implementation challenges

more details in: #2727 (comment)
@QuenKar QuenKar added the C-enhancement Category Enhancements label Nov 15, 2023
@QuenKar QuenKar self-assigned this Nov 16, 2023
@QuenKar QuenKar mentioned this issue Nov 17, 2023
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@QuenKar QuenKar

Labels
C-enhancement Category Enhancements
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: unit test for mutable vector QuenKar/greptimedb
1 participant
@QuenKar