-
Notifications
You must be signed in to change notification settings - Fork 328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add export data to migrate tool #2610
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rest LGTM
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #2610 +/- ##
===========================================
- Coverage 85.23% 84.77% -0.46%
===========================================
Files 738 738
Lines 118249 118319 +70
===========================================
- Hits 100794 100310 -484
- Misses 17455 18009 +554 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
||
format!( | ||
"copy {} from '{}' with (format='parquet');\n", | ||
filename.replace(".parquet", ""), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion(non-blocking): Can we assign this to a variable first? I took a long time to realize that it is the table name.
let table_name = filename.replace(".parquet", "");
}) | ||
.collect::<Vec<_>>() | ||
.join(""); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we collect it into a string?
}) | |
.collect::<Vec<_>>() | |
.join(""); | |
}) | |
.collect::<String>(); |
I hereby agree to the terms of the GreptimeDB CLA
What's changed and what's your intention?
This pr mainly adds export-data to cli export tool.
export
e.g
result
import
Checklist
Refer to a related PR or issue link (optional)