Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: export tool minor refactor #2612

Merged
merged 8 commits into from
Nov 6, 2023
Merged

chore: export tool minor refactor #2612

merged 8 commits into from
Nov 6, 2023

Conversation

shuiyisong
Copy link
Contributor

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

This pr is a cr issue fix to #2610

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.

Refer to a related PR or issue link (optional)

@shuiyisong shuiyisong changed the title chore: minor refactor chore: export tool minor refactor Oct 17, 2023
@codecov
Copy link

codecov bot commented Oct 17, 2023 •
edited
Loading

Codecov Report

Merging #2612 (49d54be) into develop (5b8e506) will decrease coverage by 0.43%.
Report is 64 commits behind head on develop.
The diff coverage is 0.00%.

❗ Current head 49d54be differs from pull request most recent head 0cd5392. Consider uploading reports for the commit 0cd5392 to get more accurate results

Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #2612      +/-   ##
===========================================
- Coverage    85.14%   84.71%   -0.43%     
===========================================
  Files          738      762      +24     
  Lines       118590   121877    +3287     
===========================================
+ Hits        100974   103252    +2278     
- Misses       17616    18625    +1009

evenyag
evenyag reviewed Oct 17, 2023
View reviewed changes
src/cmd/src/cli/export.rs Outdated Show resolved Hide resolved
@killme2008
Copy link
Contributor

@shuiyisong PLTAL

@shuiyisong
Copy link
Contributor Author

@evenyag @waynexia PTAL 😀

waynexia
waynexia approved these changes Nov 6, 2023
View reviewed changes
Copy link
Member

@waynexia waynexia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

src/cmd/src/cli/export.rs Show resolved Hide resolved
evenyag
evenyag approved these changes Nov 6, 2023
View reviewed changes
Copy link
Contributor

@evenyag evenyag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM.

src/cmd/src/cli/export.rs Outdated Show resolved Hide resolved
src/cmd/src/cli/export.rs Outdated Show resolved Hide resolved
@shuiyisong shuiyisong enabled auto-merge November 6, 2023 16:38
@shuiyisong shuiyisong added this pull request to the merge queue Nov 6, 2023
Merged via the queue into GreptimeTeam:develop with commit 7e0dcfc Nov 6, 2023
11 checks passed
@shuiyisong shuiyisong deleted the chore/export_cr_fix branch November 6, 2023 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@waynexia waynexia waynexia approved these changes

@evenyag evenyag evenyag approved these changes

@fengys1996 fengys1996 Awaiting requested review from fengys1996

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@shuiyisong @killme2008 @evenyag @waynexia