Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix!: align frontend cmd name to rpc_* #2609

Merged
merged 1 commit into from
Oct 17, 2023

Conversation

masonyc
Copy link
Contributor

@masonyc masonyc commented Oct 16, 2023

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

As title.

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.

Refer to a related PR or issue link (optional)

#2571

@codecov
Copy link

codecov bot commented Oct 16, 2023

Codecov Report

Merging #2609 (e6b8682) into develop (d9e7b89) will decrease coverage by 0.37%.
The diff coverage is 50.00%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2609      +/-   ##
===========================================
- Coverage    85.33%   84.97%   -0.37%     
===========================================
  Files          737      737              
  Lines       118042   118042              
===========================================
- Hits        100736   100305     -431     
- Misses       17306    17737     +431     

@evenyag evenyag changed the title fix: align frontend cmd name to rpc_* fix!: align frontend cmd name to rpc_* Oct 17, 2023
@github-actions github-actions bot added the breaking-change This pull request contains breaking changes. label Oct 17, 2023
src/cmd/src/frontend.rs Show resolved Hide resolved
@waynexia waynexia enabled auto-merge October 17, 2023 03:50
@waynexia waynexia added this pull request to the merge queue Oct 17, 2023
Merged via the queue into GreptimeTeam:develop with commit 829db8c Oct 17, 2023
19 checks passed
zyy17 added a commit to zyy17/greptimedb-operator that referenced this pull request Oct 19, 2023
@masonyc masonyc deleted the fix/align-name branch October 19, 2023 07:39
daviderli614 pushed a commit to GreptimeTeam/greptimedb-operator that referenced this pull request Oct 19, 2023
* fix: modify frontend cmd options(related PR: GreptimeTeam/greptimedb#2609)

Signed-off-by: zyy17 <[email protected]>

* ci: upgrade go version from 1.18 to 1.21

* test: bump golangci-lint version from 1.50.1 to 1.54.2

---------

Signed-off-by: zyy17 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-change This pull request contains breaking changes. docs-required This change requires docs update.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants