Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix incompatibe frontend cmd opts and upgrade go version #117

Merged
merged 3 commits into from
Oct 19, 2023

Conversation

zyy17
Copy link
Collaborator

@zyy17 zyy17 commented Oct 19, 2023

  1. Modify frontend cmd options for upstream incompatible change(fix!: align frontend cmd name to rpc_* greptimedb#2609);
  2. Upgrade CI go version from 1.18 to 1.21;

@zyy17 zyy17 requested a review from daviderli614 October 19, 2023 07:17
@zyy17 zyy17 requested a review from shawnh2 October 19, 2023 07:28
@zyy17 zyy17 changed the title fix: modify frontend cmd options(related PR: https://github.com/GreptimeTeam/greptimedb/pull/2609) chore: fix incompatibe frontend cmd opts and upgrade go version Oct 19, 2023
Copy link
Member

@daviderli614 daviderli614 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@daviderli614 daviderli614 merged commit 8d083c4 into GreptimeTeam:develop Oct 19, 2023
4 checks passed
@zyy17 zyy17 deleted the fix/incompatible-opts branch October 19, 2023 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants