-
Notifications
You must be signed in to change notification settings - Fork 328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add walconfig dir back #2606
Conversation
Cool! Thank u for your contribution. Looks like we need to use this parameter in greptimedb/src/datanode/src/datanode.rs Line 368 in 6e87ac0
If it is presented(not none), we use it instead of |
@shoothzj Looks like there is a code format issue. Please run the Or you can use a |
@killme2008 When I run the
|
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #2606 +/- ##
===========================================
- Coverage 85.33% 84.97% -0.37%
===========================================
Files 737 737
Lines 118030 118042 +12
===========================================
- Hits 100724 100306 -418
- Misses 17306 17736 +430 |
@shoothzj Have you installed clippy? https://github.com/rust-lang/rust-clippy |
Sorry, my mistake. The full command is |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thank u.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Others LGTM
Signed-off-by: ZhangJian He <[email protected]>
add docs PR GreptimeTeam/docs#651. |
Signed-off-by: ZhangJian He <[email protected]>
I hereby agree to the terms of the GreptimeDB CLA
What's changed and what's your intention?
PLEASE DO NOT LEAVE THIS EMPTY !!!
Add Wal dir config back.
Checklist
Refer to a related PR or issue link (optional)
#2312