Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert the wal_dir back #2492

Closed
killme2008 opened this issue Sep 26, 2023 · 5 comments
Closed

Revert the wal_dir back #2492

killme2008 opened this issue Sep 26, 2023 · 5 comments
Assignees
Labels
C-enhancement Category Enhancements good first issue Good for newcomers help wanted Extra attention is needed

Comments

@killme2008
Copy link
Contributor

What type of enhancement is this?

Configuration

What does the enhancement do?

It was removed in f71aa37

But it's helpful when you have different disks for wal and data, so let's add it back.

Implementation challenges

No response

@killme2008 killme2008 added C-enhancement Category Enhancements good first issue Good for newcomers help wanted Extra attention is needed labels Sep 26, 2023
@shoothzj
Copy link
Contributor

I am interested in this change. Could you please assign this to me?

@killme2008
Copy link
Contributor Author

I am interested in this change. Could you please assign this to me?

Cool, it's yours.

@tisonkun
Copy link
Collaborator

tisonkun commented Nov 9, 2023

@killme2008 I noticed that now we use these three consts for different dir:

/// WAL dir for local file storage
pub const WAL_DIR: &str = "wal/";

/// Data dir for table engines
pub const DATA_DIR: &str = "data/";

/// Cluster state dir
pub const CLUSTER_DIR: &str = "cluster/";

Does this issue mean to use a configurable or at least variable wal_dir to replace the const? What for the rest two?

Besides, this seems be closed by d9e7b89.

@tisonkun
Copy link
Collaborator

tisonkun commented Nov 9, 2023

The three consts seem default value.

@killme2008
Copy link
Contributor Author

@tisonkun Looks like it was fixed via #2606

Thank you. You can find other issues if you are interested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-enhancement Category Enhancements good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants