feat(mito): Implement operations like concat and sort for Batch #2203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evenyag
force-pushed
the
feat/mito2-batch-op
branch
from
438002e to
719a98f
Compare
Codecov Report
@@ Coverage Diff @@
## develop #2203 +/- ##
===========================================
+ Coverage 84.64% 84.65% +0.01%
===========================================
Files 702 703 +1
Lines 113824 114394 +570
===========================================
+ Hits 96341 96839 +498
- Misses 17483 17555 +72 |
2 tasks
waynexia
reviewed
Aug 21, 2023
v0y4g3r
reviewed
Aug 22, 2023
waynexia
reviewed
Aug 22, 2023
Don't return Option in get_timestamp()/get_sequence()
waynexia
approved these changes
Aug 22, 2023
paomian
pushed a commit
to paomian/greptimedb
that referenced
this pull request
Oct 19, 2023
…timeTeam#2203) * feat: Implement slice and first/last timestamp for Batch * feat(mito): implements sort/concat for Batch * chore: fix typo * chore: remove comments * feat: sort and dedup * test: test batch operations * chore: cast enum to test op type * test: test filter related api * sytle: fix clippy * docs: comment for slice * chore: address CR comment Don't return Option in get_timestamp()/get_sequence()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the GreptimeDB CLA
What's changed and what's your intention?
This PR implements some useful operations for Batch
concat(), concat multiple batches into onesort_and_dedup(), sort and dedup theBatchin placeslice(), slice theBatchfilter_deleted(), remove rows withOpType::DeleteChecklist
Refer to a related PR or issue link (optional)