feat(mito): merge reader for mito2 #2210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #2210 +/- ##
===========================================
- Coverage 84.92% 84.59% -0.33%
===========================================
Files 704 705 +1
Lines 114826 115167 +341
===========================================
- Hits 97512 97425 -87
- Misses 17314 17742 +428 |
40 tasks
waynexia
approved these changes
Aug 24, 2023
paomian
pushed a commit
to paomian/greptimedb
that referenced
this pull request
Oct 19, 2023
* feat: Implement slice and first/last timestamp for Batch * feat(mito): implements sort/concat for Batch * chore: fix typo * chore: remove comments * feat: sort and dedup * test: test batch operations * chore: cast enum to test op type * test: test filter related api * sytle: fix clippy * feat: implement Node and CompareFirst * feat: merge reader wip * feat: merge wip * feat: use batch's operation to sort and dedup * feat: implement BatchReader for MergeReader * feat: simplify codes * test: test merge reader * refactor: use test util to create batch * refactor: remove unused imports * feat: update comment * chore: remove metadata() from Source * chroe: update comment * feat: source supports batch iterator * chore: update comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the GreptimeDB CLA
What's changed and what's your intention?
This PR implements a
MergeReaderto merge multiple sorted batch sources into one and also remove duplications.The
MergeReaderrequires all input source yields sorted and deduplicated Batches. The reader uses a heap to sort and collect batches for each series.Currently, the reader only removes deleted rows but doesn't filter rows by sequence for simplicity and performance reason. So it is possible to read rows in another write request that is still writing.
Checklist
Refer to a related PR or issue link (optional)